* [PATCH 1/4] arm64: dts: qcom: Use hyphen in node names
2026-07-06 7:03 [PATCH 0/4] arm64: dts: qcom: Few style cleanups Krzysztof Kozlowski
@ 2026-07-06 7:03 ` Krzysztof Kozlowski
2026-07-06 7:10 ` sashiko-bot
` (2 more replies)
2026-07-06 7:03 ` [PATCH 2/4] arm64: dts: qcom: Use tab for indentation Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 3 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-06 7:03 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Krzysztof Kozlowski
DTS coding style prefers hyphens instead of underscores in the node
names. Change should be safe, because node names are not considered an
ABI.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
arch/arm/boot/dts/qcom/qcom-apq8064-pins.dtsi | 2 +-
arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 2 +-
arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts | 2 +-
arch/arm64/boot/dts/qcom/lemans-evk-camera.dtso | 2 +-
arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi | 4 ++--
arch/arm64/boot/dts/qcom/lemans.dtsi | 2 +-
arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts | 2 +-
arch/arm64/boot/dts/qcom/monaco.dtsi | 2 +-
arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo-common.dtsi | 8 ++++----
9 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/arch/arm/boot/dts/qcom/qcom-apq8064-pins.dtsi b/arch/arm/boot/dts/qcom/qcom-apq8064-pins.dtsi
index e53de709e9d1..e95da761234b 100644
--- a/arch/arm/boot/dts/qcom/qcom-apq8064-pins.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-apq8064-pins.dtsi
@@ -87,7 +87,7 @@ gsbi7_uart_2pins: gsbi7-uart-2pins-state {
function = "gsbi7";
};
- gsbi7_uart_4pins: gsbi7_uart_4pins-state {
+ gsbi7_uart_4pins: gsbi7-uart-4pins-state {
pins = "gpio82", "gpio83", "gpio84", "gpio85";
function = "gsbi7";
};
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
index 95be1d2e214f..06c0af0aa317 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
@@ -1866,7 +1866,7 @@ cci_i2c1_sleep: cci-i2c1-sleep-pins {
};
};
- spi8_default: spi8_default-state {
+ spi8_default: spi8-default-state {
mosi-pins {
pins = "gpio45";
function = "blsp_spi8";
diff --git a/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
index 07c10c84eefa..2c0590617ac4 100644
--- a/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
+++ b/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
@@ -55,7 +55,7 @@ vph_pwr: vph-pwr-regulator {
regulator-max-microvolt = <3700000>;
};
- vreg_bob_3p3: pmx65_bob {
+ vreg_bob_3p3: pmx65-bob-regulator {
compatible = "regulator-fixed";
regulator-name = "vreg_bob_3p3";
regulator-min-microvolt = <3300000>;
diff --git a/arch/arm64/boot/dts/qcom/lemans-evk-camera.dtso b/arch/arm64/boot/dts/qcom/lemans-evk-camera.dtso
index 4600d5441cce..a4c6d39cf777 100644
--- a/arch/arm64/boot/dts/qcom/lemans-evk-camera.dtso
+++ b/arch/arm64/boot/dts/qcom/lemans-evk-camera.dtso
@@ -14,7 +14,7 @@
#include <dt-bindings/gpio/gpio.h>
&{/} {
- vreg_cam1_1p8: vreg_cam1_1p8 {
+ vreg_cam1_1p8: cam1-1p8-regulator {
compatible = "regulator-fixed";
regulator-name = "vreg_cam1_1p8";
startup-delay-us = <10000>;
diff --git a/arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi b/arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi
index 40f88498999b..cefb8ff00806 100644
--- a/arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi
@@ -63,7 +63,7 @@ vreg_3p3: vreg-3p3-regulator {
regulator-max-microvolt = <3300000>;
};
- vreg_conn_1p8: vreg_conn_1p8 {
+ vreg_conn_1p8: vreg-conn-1p8-regulator {
compatible = "regulator-fixed";
regulator-name = "vreg_conn_1p8";
startup-delay-us = <4000>;
@@ -71,7 +71,7 @@ vreg_conn_1p8: vreg_conn_1p8 {
gpio = <&pmm8654au_1_gpios 4 GPIO_ACTIVE_HIGH>;
};
- vreg_conn_pa: vreg_conn_pa {
+ vreg_conn_pa: vreg-conn-pa-regulator {
compatible = "regulator-fixed";
regulator-name = "vreg_conn_pa";
startup-delay-us = <4000>;
diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qcom/lemans.dtsi
index 353a6e6fd3ac..e5a57a340cd8 100644
--- a/arch/arm64/boot/dts/qcom/lemans.dtsi
+++ b/arch/arm64/boot/dts/qcom/lemans.dtsi
@@ -1041,7 +1041,7 @@ qfprom: efuse@784000 {
#address-cells = <1>;
#size-cells = <1>;
- gpu_speed_bin: gpu_speed_bin@240c {
+ gpu_speed_bin: gpu-speed-bin@240c {
reg = <0x240c 0x1>;
bits = <0 8>;
};
diff --git a/arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts b/arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts
index 7393978926e4..0796d9dbe158 100644
--- a/arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts
+++ b/arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts
@@ -136,7 +136,7 @@ ramoops@81f20000 {
* ABL is powering down display and controller if this node is
* not named exactly "splash_region".
*/
- splash_region@e3940000 {
+ splash@e3940000 {
reg = <0x0 0xe3940000 0x0 0x2b00000>;
no-map;
};
diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/qcom/monaco.dtsi
index a350a8ba48fa..c50ce1843703 100644
--- a/arch/arm64/boot/dts/qcom/monaco.dtsi
+++ b/arch/arm64/boot/dts/qcom/monaco.dtsi
@@ -2927,7 +2927,7 @@ ws-pins {
};
};
- lpi_i2s4_active: lpi_i2s4-active-state {
+ lpi_i2s4_active: lpi-i2s4-active-state {
data0-pins {
pins = "gpio17";
function = "i2s4_data";
diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo-common.dtsi b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo-common.dtsi
index 7eecd9dc3028..70c130c5426c 100644
--- a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo-common.dtsi
@@ -46,22 +46,22 @@ framebuffer {
};
reserved-memory {
- adsp_pil_mem: adsp_pil_mem@55300000 {
+ adsp_pil_mem: adsp-pil-mem@55300000 {
reg = <0x0 0x55300000 0x0 0x2200000>;
no-map;
};
- ipa_fw_mem: ipa_fw_mem@57500000 {
+ ipa_fw_mem: ipa-fw-mem@57500000 {
reg = <0x0 0x57500000 0x0 0x10000>;
no-map;
};
- ipa_gsi_mem: ipa_gsi_mem@57510000 {
+ ipa_gsi_mem: ipa-gsi-mem@57510000 {
reg = <0x0 0x57510000 0x0 0x5000>;
no-map;
};
- gpu_mem: gpu_mem@57515000 {
+ gpu_mem: gpu-mem@57515000 {
reg = <0x0 0x57515000 0x0 0x2000>;
no-map;
};
--
2.53.0
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 1/4] arm64: dts: qcom: Use hyphen in node names
2026-07-06 7:03 ` [PATCH 1/4] arm64: dts: qcom: Use hyphen in node names Krzysztof Kozlowski
@ 2026-07-06 7:10 ` sashiko-bot
2026-07-06 7:17 ` Krzysztof Kozlowski
2026-07-06 7:17 ` Krzysztof Kozlowski
2026-07-06 7:19 ` Luca Weiss
2 siblings, 1 reply; 13+ messages in thread
From: sashiko-bot @ 2026-07-06 7:10 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: robh, conor+dt, devicetree
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] Renaming the `splash_region` node to `splash` violates an explicit bootloader ABI, breaking continuous splash screen and display handover.
- [Medium] The commit modifies node names beyond simply replacing underscores with hyphens, introducing a mismatch between the commit message and the actual changes.
--
commit f5e94b2fb05705d86098917e535c3beb4b025cf6
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
arm64: dts: qcom: Use hyphen in node names
This commit renames several device tree nodes to use hyphens instead of
underscores to align with DTS coding style. The commit message notes this
should be safe since node names are not considered an ABI.
> DTS coding style prefers hyphens instead of underscores in the node
> names. Change should be safe, because node names are not considered an
> ABI.
[Severity: High]
Is it accurate that node names are never considered an ABI? In some cases,
firmware components like ABL rely on exact node names for hardware handover.
[Severity: Medium]
The commit message claims to only replace underscores with hyphens in node
names, but the patch also alters prefixes and adds new "-regulator" suffixes
that go beyond the stated scope.
[ ... ]
> diff --git a/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
> index 07c10c84eefa1..2c0590617ac46 100644
> --- a/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
> +++ b/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
> @@ -55,7 +55,7 @@ vph_pwr: vph-pwr-regulator {
> regulator-max-microvolt = <3700000>;
> };
>
> - vreg_bob_3p3: pmx65_bob {
> + vreg_bob_3p3: pmx65-bob-regulator {
^^^^^^^^^^^^^^^^^^^
[Severity: Medium]
This node was renamed by appending a completely new "-regulator" suffix not
mentioned in the commit message. Is this intentional?
> compatible = "regulator-fixed";
> regulator-name = "vreg_bob_3p3";
> regulator-min-microvolt = <3300000>;
[ ... ]
> diff --git a/arch/arm64/boot/dts/qcom/lemans-evk-camera.dtso b/arch/arm64/boot/dts/qcom/lemans-evk-camera.dtso
> index 4600d5441cce4..a4c6d39cf7778 100644
> --- a/arch/arm64/boot/dts/qcom/lemans-evk-camera.dtso
> +++ b/arch/arm64/boot/dts/qcom/lemans-evk-camera.dtso
> @@ -14,7 +14,7 @@
> #include <dt-bindings/gpio/gpio.h>
>
> &{/} {
> - vreg_cam1_1p8: vreg_cam1_1p8 {
> + vreg_cam1_1p8: cam1-1p8-regulator {
^^^^^^^^^^^^^^^^^^
[Severity: Medium]
The node prefix and suffix were arbitrarily altered here, going beyond a
simple underscore replacement. Could the commit message be updated to
reflect these additional naming changes?
> compatible = "regulator-fixed";
> regulator-name = "vreg_cam1_1p8";
> startup-delay-us = <10000>;
[ ... ]
> diff --git a/arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts b/arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts
> index 7393978926e44..0796d9dbe1582 100644
> --- a/arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts
> +++ b/arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts
> @@ -136,7 +136,7 @@ ramoops@81f20000 {
> * ABL is powering down display and controller if this node is
> * not named exactly "splash_region".
> */
> - splash_region@e3940000 {
> + splash@e3940000 {
^^^^^^^^^^^^^^^
[Severity: High]
Does renaming "splash_region" to "splash" violate the explicit bootloader
ABI documented in the comment directly above?
The ABL bootloader parses the device tree to find the memory region node
named exactly "splash_region". Changing this name could cause the lookup
to fail and inadvertently power down the display hardware during the
bootloader-to-kernel transition.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260706-dts-qcom-style-checker-v1-0-16ce82a2bcfd@oss.qualcomm.com?part=1
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 1/4] arm64: dts: qcom: Use hyphen in node names
2026-07-06 7:10 ` sashiko-bot
@ 2026-07-06 7:17 ` Krzysztof Kozlowski
0 siblings, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-06 7:17 UTC (permalink / raw)
To: sashiko-reviews; +Cc: robh, conor+dt, devicetree
On 06/07/2026 09:10, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [High] Renaming the `splash_region` node to `splash` violates an explicit bootloader ABI, breaking continuous splash screen and display handover.
ack
> - [Medium] The commit modifies node names beyond simply replacing underscores with hyphens, introducing a mismatch between the commit message and the actual changes.
No.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/4] arm64: dts: qcom: Use hyphen in node names
2026-07-06 7:03 ` [PATCH 1/4] arm64: dts: qcom: Use hyphen in node names Krzysztof Kozlowski
2026-07-06 7:10 ` sashiko-bot
@ 2026-07-06 7:17 ` Krzysztof Kozlowski
2026-07-06 7:19 ` Luca Weiss
2 siblings, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-06 7:17 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 06/07/2026 09:03, Krzysztof Kozlowski wrote:
> index 7393978926e4..0796d9dbe158 100644
> --- a/arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts
> +++ b/arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts
> @@ -136,7 +136,7 @@ ramoops@81f20000 {
> * ABL is powering down display and controller if this node is
> * not named exactly "splash_region".
> */
If I only read comments... This will cause DTS style checker warning.
Honestly, we should not accept such code. Bootloader vendors were told
about ABI, they just ignore the problem because they can get away with it.
> - splash_region@e3940000 {
> + splash@e3940000 {
> reg = <0x0 0xe3940000 0x0 0x2b00000>;
> no-map;
> };
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 1/4] arm64: dts: qcom: Use hyphen in node names
2026-07-06 7:03 ` [PATCH 1/4] arm64: dts: qcom: Use hyphen in node names Krzysztof Kozlowski
2026-07-06 7:10 ` sashiko-bot
2026-07-06 7:17 ` Krzysztof Kozlowski
@ 2026-07-06 7:19 ` Luca Weiss
2026-07-06 7:37 ` Krzysztof Kozlowski
2 siblings, 1 reply; 13+ messages in thread
From: Luca Weiss @ 2026-07-06 7:19 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On Mon Jul 6, 2026 at 9:03 AM CEST, Krzysztof Kozlowski wrote:
> DTS coding style prefers hyphens instead of underscores in the node
> names. Change should be safe, because node names are not considered an
> ABI.
Until Qualcomm decides they are ABI :(
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> arch/arm/boot/dts/qcom/qcom-apq8064-pins.dtsi | 2 +-
> arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 2 +-
> arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts | 2 +-
> arch/arm64/boot/dts/qcom/lemans-evk-camera.dtso | 2 +-
> arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi | 4 ++--
> arch/arm64/boot/dts/qcom/lemans.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts | 2 +-
> arch/arm64/boot/dts/qcom/monaco.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo-common.dtsi | 8 ++++----
> 9 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom/qcom-apq8064-pins.dtsi b/arch/arm/boot/dts/qcom/qcom-apq8064-pins.dtsi
> index e53de709e9d1..e95da761234b 100644
> --- a/arch/arm/boot/dts/qcom/qcom-apq8064-pins.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-apq8064-pins.dtsi
> @@ -87,7 +87,7 @@ gsbi7_uart_2pins: gsbi7-uart-2pins-state {
> function = "gsbi7";
> };
>
> - gsbi7_uart_4pins: gsbi7_uart_4pins-state {
> + gsbi7_uart_4pins: gsbi7-uart-4pins-state {
> pins = "gpio82", "gpio83", "gpio84", "gpio85";
> function = "gsbi7";
> };
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
> index 95be1d2e214f..06c0af0aa317 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
> @@ -1866,7 +1866,7 @@ cci_i2c1_sleep: cci-i2c1-sleep-pins {
> };
> };
>
> - spi8_default: spi8_default-state {
> + spi8_default: spi8-default-state {
> mosi-pins {
> pins = "gpio45";
> function = "blsp_spi8";
> diff --git a/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
> index 07c10c84eefa..2c0590617ac4 100644
> --- a/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
> +++ b/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
> @@ -55,7 +55,7 @@ vph_pwr: vph-pwr-regulator {
> regulator-max-microvolt = <3700000>;
> };
>
> - vreg_bob_3p3: pmx65_bob {
> + vreg_bob_3p3: pmx65-bob-regulator {
> compatible = "regulator-fixed";
> regulator-name = "vreg_bob_3p3";
> regulator-min-microvolt = <3300000>;
> diff --git a/arch/arm64/boot/dts/qcom/lemans-evk-camera.dtso b/arch/arm64/boot/dts/qcom/lemans-evk-camera.dtso
> index 4600d5441cce..a4c6d39cf777 100644
> --- a/arch/arm64/boot/dts/qcom/lemans-evk-camera.dtso
> +++ b/arch/arm64/boot/dts/qcom/lemans-evk-camera.dtso
> @@ -14,7 +14,7 @@
> #include <dt-bindings/gpio/gpio.h>
>
> &{/} {
> - vreg_cam1_1p8: vreg_cam1_1p8 {
> + vreg_cam1_1p8: cam1-1p8-regulator {
> compatible = "regulator-fixed";
> regulator-name = "vreg_cam1_1p8";
> startup-delay-us = <10000>;
> diff --git a/arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi b/arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi
> index 40f88498999b..cefb8ff00806 100644
> --- a/arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/lemans-ride-common.dtsi
> @@ -63,7 +63,7 @@ vreg_3p3: vreg-3p3-regulator {
> regulator-max-microvolt = <3300000>;
> };
>
> - vreg_conn_1p8: vreg_conn_1p8 {
> + vreg_conn_1p8: vreg-conn-1p8-regulator {
> compatible = "regulator-fixed";
> regulator-name = "vreg_conn_1p8";
> startup-delay-us = <4000>;
> @@ -71,7 +71,7 @@ vreg_conn_1p8: vreg_conn_1p8 {
> gpio = <&pmm8654au_1_gpios 4 GPIO_ACTIVE_HIGH>;
> };
>
> - vreg_conn_pa: vreg_conn_pa {
> + vreg_conn_pa: vreg-conn-pa-regulator {
> compatible = "regulator-fixed";
> regulator-name = "vreg_conn_pa";
> startup-delay-us = <4000>;
> diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qcom/lemans.dtsi
> index 353a6e6fd3ac..e5a57a340cd8 100644
> --- a/arch/arm64/boot/dts/qcom/lemans.dtsi
> +++ b/arch/arm64/boot/dts/qcom/lemans.dtsi
> @@ -1041,7 +1041,7 @@ qfprom: efuse@784000 {
> #address-cells = <1>;
> #size-cells = <1>;
>
> - gpu_speed_bin: gpu_speed_bin@240c {
> + gpu_speed_bin: gpu-speed-bin@240c {
> reg = <0x240c 0x1>;
> bits = <0 8>;
> };
> diff --git a/arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts b/arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts
> index 7393978926e4..0796d9dbe158 100644
> --- a/arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts
> +++ b/arch/arm64/boot/dts/qcom/milos-nothing-asteroids.dts
> @@ -136,7 +136,7 @@ ramoops@81f20000 {
> * ABL is powering down display and controller if this node is
> * not named exactly "splash_region".
> */
> - splash_region@e3940000 {
> + splash@e3940000 {
Please read the comment above, newer ABLs explicitly check for
"splash_region" being present.
Regards
Luca
> reg = <0x0 0xe3940000 0x0 0x2b00000>;
> no-map;
> };
> diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/qcom/monaco.dtsi
> index a350a8ba48fa..c50ce1843703 100644
> --- a/arch/arm64/boot/dts/qcom/monaco.dtsi
> +++ b/arch/arm64/boot/dts/qcom/monaco.dtsi
> @@ -2927,7 +2927,7 @@ ws-pins {
> };
> };
>
> - lpi_i2s4_active: lpi_i2s4-active-state {
> + lpi_i2s4_active: lpi-i2s4-active-state {
> data0-pins {
> pins = "gpio17";
> function = "i2s4_data";
> diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo-common.dtsi b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo-common.dtsi
> index 7eecd9dc3028..70c130c5426c 100644
> --- a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo-common.dtsi
> @@ -46,22 +46,22 @@ framebuffer {
> };
>
> reserved-memory {
> - adsp_pil_mem: adsp_pil_mem@55300000 {
> + adsp_pil_mem: adsp-pil-mem@55300000 {
> reg = <0x0 0x55300000 0x0 0x2200000>;
> no-map;
> };
>
> - ipa_fw_mem: ipa_fw_mem@57500000 {
> + ipa_fw_mem: ipa-fw-mem@57500000 {
> reg = <0x0 0x57500000 0x0 0x10000>;
> no-map;
> };
>
> - ipa_gsi_mem: ipa_gsi_mem@57510000 {
> + ipa_gsi_mem: ipa-gsi-mem@57510000 {
> reg = <0x0 0x57510000 0x0 0x5000>;
> no-map;
> };
>
> - gpu_mem: gpu_mem@57515000 {
> + gpu_mem: gpu-mem@57515000 {
> reg = <0x0 0x57515000 0x0 0x2000>;
> no-map;
> };
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 1/4] arm64: dts: qcom: Use hyphen in node names
2026-07-06 7:19 ` Luca Weiss
@ 2026-07-06 7:37 ` Krzysztof Kozlowski
0 siblings, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-06 7:37 UTC (permalink / raw)
To: Luca Weiss, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 06/07/2026 09:19, Luca Weiss wrote:
> On Mon Jul 6, 2026 at 9:03 AM CEST, Krzysztof Kozlowski wrote:
>> DTS coding style prefers hyphens instead of underscores in the node
>> names. Change should be safe, because node names are not considered an
>> ABI.
>
> Until Qualcomm decides they are ABI :(
If such node-name-ABI ever comes from Qualcomm, I will NAK :)
Sashiko also pointed out the error and I will be sending v2.
I will introduce shellcheck-style exceptions for warnings to the
checker. But first let's fix all the warnings :)
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 2/4] arm64: dts: qcom: Use tab for indentation
2026-07-06 7:03 [PATCH 0/4] arm64: dts: qcom: Few style cleanups Krzysztof Kozlowski
2026-07-06 7:03 ` [PATCH 1/4] arm64: dts: qcom: Use hyphen in node names Krzysztof Kozlowski
@ 2026-07-06 7:03 ` Krzysztof Kozlowski
2026-07-06 8:25 ` Konrad Dybcio
2026-07-06 7:03 ` [PATCH 3/4] arm64: dts: qcom: Use lowercase hex for unit addresses and values Krzysztof Kozlowski
2026-07-06 7:03 ` [PATCH 4/4] arm64: dts: qcom: Correct whitespace around '=' Krzysztof Kozlowski
3 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-06 7:03 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Krzysztof Kozlowski
Correct mix of tabs+spaces into proper tab indented lines.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso | 2 +-
arch/arm64/boot/dts/qcom/sm8750.dtsi | 12 ++--
arch/arm64/boot/dts/qcom/talos.dtsi | 64 +++++++++++-----------
3 files changed, 39 insertions(+), 39 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso
index a82c26b7eae8..9872d5cb83bd 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc-usb-host.dtso
@@ -4,5 +4,5 @@
/plugin/;
&usb {
- dr_mode = "host";
+ dr_mode = "host";
};
diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
index fafed417c66f..71a70d051283 100644
--- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
@@ -2085,12 +2085,12 @@ aggre2_noc: interconnect@1700000 {
};
cambistmclkcc: clock-controller@1760000 {
- compatible = "qcom,sm8750-cambistmclkcc";
- reg = <0x0 0x1760000 0x0 0x6000>;
- clocks = <&gcc GCC_CAM_BIST_MCLK_AHB_CLK>,
- <&bi_tcxo_div2>,
- <&bi_tcxo_ao_div2>,
- <&sleep_clk>;
+ compatible = "qcom,sm8750-cambistmclkcc";
+ reg = <0x0 0x1760000 0x0 0x6000>;
+ clocks = <&gcc GCC_CAM_BIST_MCLK_AHB_CLK>,
+ <&bi_tcxo_div2>,
+ <&bi_tcxo_ao_div2>,
+ <&sleep_clk>;
power-domains = <&rpmhpd RPMHPD_MMCX>,
<&rpmhpd RPMHPD_MX>;
required-opps = <&rpmhpd_opp_low_svs>,
diff --git a/arch/arm64/boot/dts/qcom/talos.dtsi b/arch/arm64/boot/dts/qcom/talos.dtsi
index fb1bbc51bb8a..b2f9e50ea5a0 100644
--- a/arch/arm64/boot/dts/qcom/talos.dtsi
+++ b/arch/arm64/boot/dts/qcom/talos.dtsi
@@ -50,10 +50,10 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ACTIVE_ONLY>,
<&osm_l3 MASTER_OSM_L3_APPS &osm_l3 SLAVE_OSM_L3>;
l2_0: l2-cache {
- compatible = "cache";
- cache-level = <2>;
- cache-unified;
- next-level-cache = <&l3_0>;
+ compatible = "cache";
+ cache-level = <2>;
+ cache-unified;
+ next-level-cache = <&l3_0>;
};
};
@@ -75,10 +75,10 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ACTIVE_ONLY>,
<&osm_l3 MASTER_OSM_L3_APPS &osm_l3 SLAVE_OSM_L3>;
l2_100: l2-cache {
- compatible = "cache";
- cache-level = <2>;
- cache-unified;
- next-level-cache = <&l3_0>;
+ compatible = "cache";
+ cache-level = <2>;
+ cache-unified;
+ next-level-cache = <&l3_0>;
};
};
@@ -100,10 +100,10 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ACTIVE_ONLY>,
<&osm_l3 MASTER_OSM_L3_APPS &osm_l3 SLAVE_OSM_L3>;
l2_200: l2-cache {
- compatible = "cache";
- cache-level = <2>;
- cache-unified;
- next-level-cache = <&l3_0>;
+ compatible = "cache";
+ cache-level = <2>;
+ cache-unified;
+ next-level-cache = <&l3_0>;
};
};
@@ -125,10 +125,10 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ACTIVE_ONLY>,
<&osm_l3 MASTER_OSM_L3_APPS &osm_l3 SLAVE_OSM_L3>;
l2_300: l2-cache {
- compatible = "cache";
- cache-level = <2>;
- cache-unified;
- next-level-cache = <&l3_0>;
+ compatible = "cache";
+ cache-level = <2>;
+ cache-unified;
+ next-level-cache = <&l3_0>;
};
};
@@ -150,10 +150,10 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ACTIVE_ONLY>,
<&osm_l3 MASTER_OSM_L3_APPS &osm_l3 SLAVE_OSM_L3>;
l2_400: l2-cache {
- compatible = "cache";
- cache-level = <2>;
- cache-unified;
- next-level-cache = <&l3_0>;
+ compatible = "cache";
+ cache-level = <2>;
+ cache-unified;
+ next-level-cache = <&l3_0>;
};
};
@@ -175,10 +175,10 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ACTIVE_ONLY>,
<&osm_l3 MASTER_OSM_L3_APPS &osm_l3 SLAVE_OSM_L3>;
l2_500: l2-cache {
- compatible = "cache";
- cache-level = <2>;
- cache-unified;
- next-level-cache = <&l3_0>;
+ compatible = "cache";
+ cache-level = <2>;
+ cache-unified;
+ next-level-cache = <&l3_0>;
};
};
@@ -201,10 +201,10 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ACTIVE_ONLY>,
<&osm_l3 MASTER_OSM_L3_APPS &osm_l3 SLAVE_OSM_L3>;
l2_600: l2-cache {
- compatible = "cache";
- cache-level = <2>;
- cache-unified;
- next-level-cache = <&l3_0>;
+ compatible = "cache";
+ cache-level = <2>;
+ cache-unified;
+ next-level-cache = <&l3_0>;
};
};
@@ -226,10 +226,10 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ACTIVE_ONLY>,
<&osm_l3 MASTER_OSM_L3_APPS &osm_l3 SLAVE_OSM_L3>;
l2_700: l2-cache {
- compatible = "cache";
- cache-level = <2>;
- cache-unified;
- next-level-cache = <&l3_0>;
+ compatible = "cache";
+ cache-level = <2>;
+ cache-unified;
+ next-level-cache = <&l3_0>;
};
};
--
2.53.0
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 3/4] arm64: dts: qcom: Use lowercase hex for unit addresses and values
2026-07-06 7:03 [PATCH 0/4] arm64: dts: qcom: Few style cleanups Krzysztof Kozlowski
2026-07-06 7:03 ` [PATCH 1/4] arm64: dts: qcom: Use hyphen in node names Krzysztof Kozlowski
2026-07-06 7:03 ` [PATCH 2/4] arm64: dts: qcom: Use tab for indentation Krzysztof Kozlowski
@ 2026-07-06 7:03 ` Krzysztof Kozlowski
2026-07-06 8:25 ` Konrad Dybcio
2026-07-06 7:03 ` [PATCH 4/4] arm64: dts: qcom: Correct whitespace around '=' Krzysztof Kozlowski
3 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-06 7:03 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Krzysztof Kozlowski
DTS coding style prefers lowercase hex. No functional change.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi | 4 ++--
arch/arm/boot/dts/qcom/qcom-mdm9615-wp8548.dtsi | 2 +-
arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi | 8 ++++----
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi
index adedcc6da1da..1a278503d340 100644
--- a/arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-ipq8064.dtsi
@@ -591,7 +591,7 @@ saw1: power-manager@2099000 {
nss_common: syscon@3000000 {
compatible = "syscon";
- reg = <0x03000000 0x0000FFFF>;
+ reg = <0x03000000 0x0000ffff>;
};
usb3_0: usb@100f8800 {
@@ -1241,7 +1241,7 @@ pcie@0 {
qsgmii_csr: syscon@1bb00000 {
compatible = "syscon";
- reg = <0x1bb00000 0x000001FF>;
+ reg = <0x1bb00000 0x000001ff>;
};
lcc: clock-controller@28000000 {
diff --git a/arch/arm/boot/dts/qcom/qcom-mdm9615-wp8548.dtsi b/arch/arm/boot/dts/qcom/qcom-mdm9615-wp8548.dtsi
index 0dd52cac0e2e..7206a33da279 100644
--- a/arch/arm/boot/dts/qcom/qcom-mdm9615-wp8548.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-mdm9615-wp8548.dtsi
@@ -15,7 +15,7 @@ / {
memory@48000000 {
device_type = "memory";
- reg = <0x48000000 0x7F00000>;
+ reg = <0x48000000 0x7f00000>;
};
};
diff --git a/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi
index b2dc0327dff8..9368fd6b8751 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi
@@ -66,8 +66,8 @@ venus_mem: venus@97800000 {
no-map;
};
- cdsp_mem: cdsp-mem@97D00000 {
- reg = <0 0x97D00000 0 0x800000>;
+ cdsp_mem: cdsp-mem@97d00000 {
+ reg = <0 0x97d00000 0 0x800000>;
no-map;
};
@@ -81,8 +81,8 @@ slpi_mem: slpi@98700000 {
no-map;
};
- spss_mem: spss@99B00000 {
- reg = <0 0x99B00000 0 0x100000>;
+ spss_mem: spss@99b00000 {
+ reg = <0 0x99b00000 0 0x100000>;
no-map;
};
--
2.53.0
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 4/4] arm64: dts: qcom: Correct whitespace around '='
2026-07-06 7:03 [PATCH 0/4] arm64: dts: qcom: Few style cleanups Krzysztof Kozlowski
` (2 preceding siblings ...)
2026-07-06 7:03 ` [PATCH 3/4] arm64: dts: qcom: Use lowercase hex for unit addresses and values Krzysztof Kozlowski
@ 2026-07-06 7:03 ` Krzysztof Kozlowski
2026-07-06 8:26 ` Konrad Dybcio
3 siblings, 1 reply; 13+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-06 7:03 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Krzysztof Kozlowski
Coding convention asks that equal character '=' in property assignment
is preceded and followed by a space.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts | 20 ++++++++++----------
arch/arm64/boot/dts/qcom/sm8750.dtsi | 2 +-
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
index ebdca0e2d2f3..0c90c886b2c3 100644
--- a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
+++ b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts
@@ -449,16 +449,16 @@ vreg_l2c: ldo2 {
regulators-2 {
compatible = "qcom,pmr735b-rpmh-regulators";
- vdd-l1-l2-supply= <&vreg_s3b>;
- vdd-l3-supply= <&vreg_s3b>;
- vdd-l4-supply= <&vreg_s1b>;
- vdd-l5-supply= <&vreg_s2b>;
- vdd-l6-supply= <&vreg_s2b>;
- vdd-l7-l8-supply= <&vreg_s2b>;
- vdd-l9-supply= <&vreg_s3b>;
- vdd-l10-supply= <&vreg_s1b>;
- vdd-l11-supply= <&vreg_s3b>;
- vdd-l12-supply= <&vreg_s3b>;
+ vdd-l1-l2-supply = <&vreg_s3b>;
+ vdd-l3-supply = <&vreg_s3b>;
+ vdd-l4-supply = <&vreg_s1b>;
+ vdd-l5-supply = <&vreg_s2b>;
+ vdd-l6-supply = <&vreg_s2b>;
+ vdd-l7-l8-supply = <&vreg_s2b>;
+ vdd-l9-supply = <&vreg_s3b>;
+ vdd-l10-supply = <&vreg_s1b>;
+ vdd-l11-supply = <&vreg_s3b>;
+ vdd-l12-supply = <&vreg_s3b>;
qcom,pmic-id = "f";
diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
index 71a70d051283..d5f3ffff0600 100644
--- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
@@ -4938,7 +4938,7 @@ port@4 {
reg = <4>;
tpda_aoss_in4: endpoint {
- remote-endpoint =<&tpdm_swao_out>;
+ remote-endpoint = <&tpdm_swao_out>;
};
};
};
--
2.53.0
^ permalink raw reply related [flat|nested] 13+ messages in thread