From: "Jose A. Perez de Azpillaga" <azpijr@gmail.com>
To: Chang Yu <marcus.yu.56@gmail.com>, Jonathan Cameron <jic23@kernel.org>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Joshua Crofts" <joshua.crofts1@gmail.com>,
"Shi Hao" <i.shihao.999@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: iio: light: add as7343
Date: Tue, 13 Oct 2026 23:23:58 +0200 [thread overview]
Message-ID: <11150412-3b60-4eef-90a1-ebbb1b6098fc@gmail.com> (raw)
In-Reply-To: <20261013115639.167433-2-marcus.yu.56@gmail.com>
On 10/13/26 1:56 PM, Chang Yu wrote:
[snip]
> +
> + reg:
> + description:
> + I2C address of the device (0x39).
> + maxItems: 1
on v4 Jonathan said "Might as well specify it as const given it can only
take that value. They you can drop the description as it won't add
anything." v6 still has the old form, looks like that got lost.
[snip]> +
> + interrupts:
> + description:
> + Open drain output active low interrupt pin.
> + maxItems: 1
> +
> + vdd-supply: true
> +
> + led-max-microamp:
> + description:
> + The driver current for the external LED connected to the LDR pin.
this wording dates from when it was ams,led-current-microamp.
leds/common.yaml defines led-max-microamp as a maximum ("risk of
hardware damage in case an excessive current is set"), i.e. the board
limit for LED_DRIVE, not the current program. please describe it as a
maximum.
--
cheers,
jose a. p-a
next prev parent reply other threads:[~2026-10-13 21:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 11:56 [PATCH v6 0/2] Add support for AS7343 multi-spectral sensor Chang Yu
2026-10-13 11:56 ` [PATCH v6 1/2] dt-bindings: iio: light: add as7343 Chang Yu
2026-10-13 12:04 ` sashiko-bot
2026-10-13 12:36 ` Joshua Crofts
2026-10-13 15:15 ` Chang Yu
2026-10-13 21:23 ` Jose A. Perez de Azpillaga [this message]
2026-10-13 11:56 ` [PATCH v6 2/2] iio: light: add AS7343 multi-spectral sensor driver Chang Yu
2026-10-13 12:35 ` Joshua Crofts
2026-10-13 16:28 ` Andy Shevchenko
2026-10-13 16:27 ` Andy Shevchenko
2026-10-14 3:17 ` Chang Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11150412-3b60-4eef-90a1-ebbb1b6098fc@gmail.com \
--to=azpijr@gmail.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=i.shihao.999@gmail.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.yu.56@gmail.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox