From: Yixun Lan <dlan@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Inochi Amaoto <inochiama@gmail.com>,
linux-clk@vger.kernel.org, linux-riscv@lists.infradead.org,
devicetree@vger.kernel.org, spacemit@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] clk: spacemit: k3: Add PCIe DBI clock
Date: Sat, 2 May 2026 11:30:16 +0000 [thread overview]
Message-ID: <20260502113016-GKA3266396@kernel.org> (raw)
In-Reply-To: <35a1764d-7328-45d2-8240-6f83eae1f1a9@oss.qualcomm.com>
Hi Krzysztof,
On 11:28 Fri 01 May , Krzysztof Kozlowski wrote:
> On 30/04/2026 12:30, Yixun Lan wrote:
> > Add PCIe DBI (Data Bus Interface) clock which was missing.
> >
> > Fixes: e371a77255b8 ("clk: spacemit: k3: add the clock tree")
>
> Describe what the bug is in your commit msg.
Since we've not yet activated the PCIe driver, so this shouldn't cause any
real bug, and as Conor already point out - this is kind of abusing Fixes tag,
so I will drop it in next version.
FYI, for problem I see while testing PCIe driver,
- DBI clock is required in DTS, so it will trigger a check warning
- the DBI clock will be in undetermined state
--
Yixun Lan (dlan)
next prev parent reply other threads:[~2026-05-02 11:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 10:30 [PATCH 0/4] riscv: spacemit: k3: some clock fixes related to PCIe Yixun Lan
2026-04-30 10:30 ` [PATCH 1/4] dt-bindings: soc: spacemit: k3: Add PCIe DBI clock IDs Yixun Lan
2026-04-30 18:55 ` Conor Dooley
2026-05-02 11:32 ` Yixun Lan
2026-05-03 17:59 ` Conor Dooley
2026-04-30 10:30 ` [PATCH 2/4] clk: spacemit: k3: Add PCIe DBI clock Yixun Lan
2026-05-01 9:28 ` Krzysztof Kozlowski
2026-05-02 11:30 ` Yixun Lan [this message]
2026-04-30 10:30 ` [PATCH 3/4] clk: spacemit: k3: Switch to pll2_d6 as parent for PCIe clock Yixun Lan
2026-04-30 10:30 ` [PATCH 4/4] clk: spacemit: k3: Fix PCIe clock register offset Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260502113016-GKA3266396@kernel.org \
--to=dlan@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=inochiama@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox