* [PATCH] dt-bindings: iio: dds: Add AD9832/AD9835 binding
@ 2026-05-08 23:37 Hungyu Lin
2026-05-08 23:50 ` sashiko-bot
2026-05-09 16:00 ` Conor Dooley
0 siblings, 2 replies; 3+ messages in thread
From: Hungyu Lin @ 2026-05-08 23:37 UTC (permalink / raw)
To: robh, krzk+dt, conor+dt
Cc: jic23, lars, michael.hennerich, linux-iio, devicetree,
linux-kernel, Hungyu Lin
Add devicetree binding documentation for AD9832 and AD9835 DDS devices.
These devices are SPI-controlled direct digital synthesizers
requiring AVDD, DVDD supplies and an external master clock.
Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
.../bindings/iio/dds/adi,ad9832.yaml | 66 +++++++++++++++++++
1 file changed, 66 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
diff --git a/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml b/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
new file mode 100644
index 000000000000..7e2eece086d0
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
@@ -0,0 +1,66 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/dds/adi,ad9832.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices AD9832 / AD9835 DDS
+
+maintainers:
+ - Hungyu Lin <dennylin0707@gmail.com>
+
+description: |
+ Analog Devices AD9832 and AD9835 are SPI-controlled direct digital
+ synthesizers (DDS) capable of generating programmable frequency and
+ phase output signals using an external master clock.
+
+properties:
+ compatible:
+ enum:
+ - adi,ad9832
+ - adi,ad9835
+
+ reg:
+ maxItems: 1
+
+ spi-max-frequency:
+ maximum: 20000000
+
+ clocks:
+ maxItems: 1
+
+ clock-names:
+ const: mclk
+
+ avdd-supply:
+ description: Analog power supply
+
+ dvdd-supply:
+ description: Digital power supply
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - clock-names
+ - avdd-supply
+ - dvdd-supply
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ad9832@0 {
+ compatible = "adi,ad9832";
+ reg = <0>;
+ spi-max-frequency = <20000000>;
+ clocks = <&mclk>;
+ clock-names = "mclk";
+ avdd-supply = <&vdd_3v3>;
+ dvdd-supply = <&vdd_3v3>;
+ };
+ };
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: iio: dds: Add AD9832/AD9835 binding
2026-05-08 23:37 [PATCH] dt-bindings: iio: dds: Add AD9832/AD9835 binding Hungyu Lin
@ 2026-05-08 23:50 ` sashiko-bot
2026-05-09 16:00 ` Conor Dooley
1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-05-08 23:50 UTC (permalink / raw)
To: Hungyu Lin; +Cc: robh, conor+dt, krzk+dt, devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing reference to standard SPI peripheral properties schema restricts valid SPI configurations.
--
commit 05158b905a98b93285ae76fe23056051bd698d9e
Author: Hungyu Lin <dennylin0707@gmail.com>
dt-bindings: iio: dds: Add AD9832/AD9835 binding
This commit adds device tree binding documentation for the AD9832 and
AD9835 SPI-controlled direct digital synthesizers.
> diff --git a/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml b/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
[ ... ]
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - avdd-supply
> + - dvdd-supply
> +
> +unevaluatedProperties: false
Does this binding need a reference to the standard SPI peripheral properties
schema?
Since unevaluatedProperties is set to false without including a reference to
/schemas/spi/spi-peripheral-props.yaml#, standard SPI properties provided by
a board's device tree (such as spi-cpol, spi-cpha, spi-cs-high, or
spi-rx-delay-us) will be incorrectly rejected by dtbs_check.
Should this schema include an allOf block to inherit the common SPI
properties so that different board designs and controller requirements can
be correctly evaluated?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260508233730.77834-1-dennylin0707@gmail.com?part=1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: iio: dds: Add AD9832/AD9835 binding
2026-05-08 23:37 [PATCH] dt-bindings: iio: dds: Add AD9832/AD9835 binding Hungyu Lin
2026-05-08 23:50 ` sashiko-bot
@ 2026-05-09 16:00 ` Conor Dooley
1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2026-05-09 16:00 UTC (permalink / raw)
To: Hungyu Lin
Cc: robh, krzk+dt, conor+dt, jic23, lars, michael.hennerich,
linux-iio, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2509 bytes --]
Jonathan,
What's the story with adding bindings for things that are in staging?
Cheers,
Conor.
On Fri, May 08, 2026 at 11:37:30PM +0000, Hungyu Lin wrote:
> Add devicetree binding documentation for AD9832 and AD9835 DDS devices.
>
> These devices are SPI-controlled direct digital synthesizers
> requiring AVDD, DVDD supplies and an external master clock.
>
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
> .../bindings/iio/dds/adi,ad9832.yaml | 66 +++++++++++++++++++
> 1 file changed, 66 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml b/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
> new file mode 100644
> index 000000000000..7e2eece086d0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/dds/adi,ad9832.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AD9832 / AD9835 DDS
> +
> +maintainers:
> + - Hungyu Lin <dennylin0707@gmail.com>
> +
> +description: |
> + Analog Devices AD9832 and AD9835 are SPI-controlled direct digital
> + synthesizers (DDS) capable of generating programmable frequency and
> + phase output signals using an external master clock.
> +
> +properties:
> + compatible:
> + enum:
> + - adi,ad9832
> + - adi,ad9835
> +
> + reg:
> + maxItems: 1
> +
> + spi-max-frequency:
> + maximum: 20000000
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + const: mclk
> +
> + avdd-supply:
> + description: Analog power supply
> +
> + dvdd-supply:
> + description: Digital power supply
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - avdd-supply
> + - dvdd-supply
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ad9832@0 {
> + compatible = "adi,ad9832";
> + reg = <0>;
> + spi-max-frequency = <20000000>;
> + clocks = <&mclk>;
> + clock-names = "mclk";
> + avdd-supply = <&vdd_3v3>;
> + dvdd-supply = <&vdd_3v3>;
> + };
> + };
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-09 16:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-08 23:37 [PATCH] dt-bindings: iio: dds: Add AD9832/AD9835 binding Hungyu Lin
2026-05-08 23:50 ` sashiko-bot
2026-05-09 16:00 ` Conor Dooley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox