[PATCH] dt-bindings: iio: dds: Add AD9832/AD9835 binding

[PATCH] dt-bindings: iio: dds: Add AD9832/AD9835 binding

[Hungyu Lin]

Add devicetree binding documentation for AD9832 and AD9835 DDS devices.

These devices are SPI-controlled direct digital synthesizers
requiring AVDD, DVDD supplies and an external master clock.

Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
 .../bindings/iio/dds/adi,ad9832.yaml          | 66 +++++++++++++++++++
 1 file changed, 66 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml

diff --git a/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml b/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
new file mode 100644
index 000000000000..7e2eece086d0
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
@@ -0,0 +1,66 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/dds/adi,ad9832.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices AD9832 / AD9835 DDS
+
+maintainers:
+  - Hungyu Lin <dennylin0707@gmail.com>
+
+description: |
+  Analog Devices AD9832 and AD9835 are SPI-controlled direct digital
+  synthesizers (DDS) capable of generating programmable frequency and
+  phase output signals using an external master clock.
+
+properties:
+  compatible:
+    enum:
+      - adi,ad9832
+      - adi,ad9835
+
+  reg:
+    maxItems: 1
+
+  spi-max-frequency:
+    maximum: 20000000
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    const: mclk
+
+  avdd-supply:
+    description: Analog power supply
+
+  dvdd-supply:
+    description: Digital power supply
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-names
+  - avdd-supply
+  - dvdd-supply
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        ad9832@0 {
+            compatible = "adi,ad9832";
+            reg = <0>;
+            spi-max-frequency = <20000000>;
+            clocks = <&mclk>;
+            clock-names = "mclk";
+            avdd-supply = <&vdd_3v3>;
+            dvdd-supply = <&vdd_3v3>;
+        };
+    };
-- 
2.34.1

Re: [PATCH] dt-bindings: iio: dds: Add AD9832/AD9835 binding

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing reference to standard SPI peripheral properties schema restricts valid SPI configurations.
--

commit 05158b905a98b93285ae76fe23056051bd698d9e
Author: Hungyu Lin <dennylin0707@gmail.com>

dt-bindings: iio: dds: Add AD9832/AD9835 binding

This commit adds device tree binding documentation for the AD9832 and
AD9835 SPI-controlled direct digital synthesizers.

> diff --git a/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml b/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - avdd-supply
> +  - dvdd-supply
> +
> +unevaluatedProperties: false

Does this binding need a reference to the standard SPI peripheral properties
schema?

Since unevaluatedProperties is set to false without including a reference to
/schemas/spi/spi-peripheral-props.yaml#, standard SPI properties provided by
a board's device tree (such as spi-cpol, spi-cpha, spi-cs-high, or
spi-rx-delay-us) will be incorrectly rejected by dtbs_check.

Should this schema include an allOf block to inherit the common SPI
properties so that different board designs and controller requirements can
be correctly evaluated?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260508233730.77834-1-dennylin0707@gmail.com?part=1

Re: [PATCH] dt-bindings: iio: dds: Add AD9832/AD9835 binding

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2509 bytes --]

Jonathan,

What's the story with adding bindings for things that are in staging?

Cheers,
Conor.

On Fri, May 08, 2026 at 11:37:30PM +0000, Hungyu Lin wrote:
> Add devicetree binding documentation for AD9832 and AD9835 DDS devices.
> 
> These devices are SPI-controlled direct digital synthesizers
> requiring AVDD, DVDD supplies and an external master clock.
> 
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
>  .../bindings/iio/dds/adi,ad9832.yaml          | 66 +++++++++++++++++++
>  1 file changed, 66 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml b/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
> new file mode 100644
> index 000000000000..7e2eece086d0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/dds/adi,ad9832.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AD9832 / AD9835 DDS
> +
> +maintainers:
> +  - Hungyu Lin <dennylin0707@gmail.com>
> +
> +description: |
> +  Analog Devices AD9832 and AD9835 are SPI-controlled direct digital
> +  synthesizers (DDS) capable of generating programmable frequency and
> +  phase output signals using an external master clock.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - adi,ad9832
> +      - adi,ad9835
> +
> +  reg:
> +    maxItems: 1
> +
> +  spi-max-frequency:
> +    maximum: 20000000
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    const: mclk
> +
> +  avdd-supply:
> +    description: Analog power supply
> +
> +  dvdd-supply:
> +    description: Digital power supply
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - avdd-supply
> +  - dvdd-supply
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        ad9832@0 {
> +            compatible = "adi,ad9832";
> +            reg = <0>;
> +            spi-max-frequency = <20000000>;
> +            clocks = <&mclk>;
> +            clock-names = "mclk";
> +            avdd-supply = <&vdd_3v3>;
> +            dvdd-supply = <&vdd_3v3>;
> +        };
> +    };
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] dt-bindings: iio: dds: Add AD9832/AD9835 binding

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

On Sat, May 09, 2026 at 05:00:35PM +0100, Conor Dooley wrote:
> Jonathan,
> 
> What's the story with adding bindings for things that are in staging?

nvm, David replied to the v3 or something of this and said no.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] dt-bindings: iio: dds: Add AD9832/AD9835 binding

[Jonathan Cameron]

On Sat, 9 May 2026 17:00:35 +0100
Conor Dooley <conor@kernel.org> wrote:

> Jonathan,
> 
> What's the story with adding bindings for things that are in staging?

In the past we've only done it as part of the final series to move
them out of staging.  Whilst the driver is in staging we've always
treated them as somewhat unstable at best.

Of course if we know another OS is using them the binding might
need to be there anyway.  Never actually had that happen however!

DDS chips are normally big and complex beasts. I'd love someone to take
on getting these drivers out of staging but it's probably not a small job.
We do have one modern DDS driver under review at the moment and that
is at least forcing us to figure out the userspace ABI - so maybe it'll
get easier when that lands.

Jonathan

> 
> Cheers,
> Conor.
> 
> On Fri, May 08, 2026 at 11:37:30PM +0000, Hungyu Lin wrote:
> > Add devicetree binding documentation for AD9832 and AD9835 DDS devices.
> > 
> > These devices are SPI-controlled direct digital synthesizers
> > requiring AVDD, DVDD supplies and an external master clock.
> > 
> > Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> > ---
> >  .../bindings/iio/dds/adi,ad9832.yaml          | 66 +++++++++++++++++++
> >  1 file changed, 66 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml b/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
> > new file mode 100644
> > index 000000000000..7e2eece086d0
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/dds/adi,ad9832.yaml
> > @@ -0,0 +1,66 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/dds/adi,ad9832.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Analog Devices AD9832 / AD9835 DDS
> > +
> > +maintainers:
> > +  - Hungyu Lin <dennylin0707@gmail.com>
> > +
> > +description: |
> > +  Analog Devices AD9832 and AD9835 are SPI-controlled direct digital
> > +  synthesizers (DDS) capable of generating programmable frequency and
> > +  phase output signals using an external master clock.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - adi,ad9832
> > +      - adi,ad9835
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  spi-max-frequency:
> > +    maximum: 20000000
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  clock-names:
> > +    const: mclk
> > +
> > +  avdd-supply:
> > +    description: Analog power supply
> > +
> > +  dvdd-supply:
> > +    description: Digital power supply
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +  - clock-names
> > +  - avdd-supply
> > +  - dvdd-supply
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    spi {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        ad9832@0 {
> > +            compatible = "adi,ad9832";
> > +            reg = <0>;
> > +            spi-max-frequency = <20000000>;
> > +            clocks = <&mclk>;
> > +            clock-names = "mclk";
> > +            avdd-supply = <&vdd_3v3>;
> > +            dvdd-supply = <&vdd_3v3>;
> > +        };
> > +    };
> > -- 
> > 2.34.1
> >