From: "Theodore Tso" <tytso@mit.edu>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Krzysztof Kozlowski <krzk@kernel.org>,
debarbos@redhat.com, Arnaldo Carvalho de Melo <acme@kernel.org>,
Konstantin Ryabitsev <mricon@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
sashiko-bot@kernel.org, sashiko-reviews@lists.linux.dev,
sashiko@lists.linux.dev,
Linux Kernel Workflows <workflows@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org, kfree@google.com
Subject: Re: Stop false review statements
Date: Sun, 17 May 2026 12:29:12 -0400 [thread overview]
Message-ID: <20260517162912.GA51520@macsyma-wired.lan> (raw)
In-Reply-To: <2026051758-superbowl-baritone-2705@gregkh>
It should also be noted that Intel's zero-day bot was (a) closed
source, and (b) was sending its test regression reports with the
linux-kernel mailing list cc'ed, and no one really complained because
it was so useful, and if Intel was willing to use very expensive
hardware in their data center to contribute reports, so long as the
reports were useful and the false-positive noise was low enough, we
decided to be grateful and not worry (too much) about the fact that
Intel's zero-day bot was closed source. (There was indeed some
grumbling in the bar at Plumbers, of course. :-)
In my opinion, we should be doing the same for Sashiko, and that's the
decision which the ext4 developers have made --- at least for ext4
patches, after an experiment where we only sent reviews to the patch
authors and the maintainer, people were satisifed that false positive
rate was low enough (with the caveats that I had previously mentioned,
but we were willing to live with them because at least for us, it was
useful enough), that we will be requesting that Sashiko reviews be
cc'ed to the ext4 mailing list.
I realize that there are some extra sensitivities around AI / LLM's,
but from the perspective of reviewing patches, I don't see any
difference between this and other closed source tools that we've used,
such as Coverity and the Zero-day bot. Not everyone will agree, of
course, but at the moment, this is a decision that we are making on a
subsystem by subsystem basis, which again, has strong historical
precedence.
Cheers,
- Ted
next prev parent reply other threads:[~2026-05-17 16:29 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-16 8:05 Stop false review statements Krzysztof Kozlowski
2026-05-16 12:11 ` Guenter Roeck
2026-05-16 12:16 ` Krzysztof Kozlowski
2026-05-16 12:23 ` Guenter Roeck
2026-05-16 12:29 ` Krzysztof Kozlowski
2026-05-16 13:24 ` Laurent Pinchart
2026-05-16 13:45 ` Krzysztof Kozlowski
2026-05-16 21:10 ` Mauro Carvalho Chehab
2026-05-17 15:21 ` Jonathan Corbet
2026-05-16 15:20 ` Konstantin Ryabitsev
2026-05-16 15:36 ` Greg KH
2026-05-16 15:41 ` Roman Gushchin
2026-05-16 15:45 ` Greg KH
2026-05-16 15:49 ` Roman Gushchin
2026-05-16 18:28 ` Arnaldo Carvalho de Melo
2026-05-16 21:29 ` Derek Barbosa
2026-05-16 21:33 ` Krzysztof Kozlowski
2026-05-16 21:59 ` Roman Gushchin
2026-05-17 8:25 ` Krzysztof Kozlowski
2026-05-17 10:05 ` Mauro Carvalho Chehab
2026-05-17 10:10 ` Willy Tarreau
2026-05-17 10:12 ` Greg KH
2026-05-17 16:29 ` Theodore Tso [this message]
2026-05-17 22:22 ` Laurent Pinchart
2026-05-17 16:39 ` Mauro Carvalho Chehab
2026-05-17 17:03 ` Guenter Roeck
2026-05-17 18:17 ` Roman Gushchin
2026-05-17 18:56 ` Mauro Carvalho Chehab
2026-05-18 5:31 ` Greg KH
2026-05-17 18:57 ` Theodore Tso
2026-05-17 19:36 ` Mauro Carvalho Chehab
2026-05-16 18:28 ` Krzysztof Kozlowski
2026-05-16 18:56 ` Roman Gushchin
2026-05-16 19:00 ` Krzysztof Kozlowski
2026-05-16 19:13 ` Guenter Roeck
2026-05-16 19:25 ` Guenter Roeck
2026-05-16 19:31 ` Roman Gushchin
2026-05-16 19:15 ` Roman Gushchin
2026-05-16 20:41 ` Theodore Tso
2026-05-17 15:56 ` Danilo Krummrich
2026-05-17 21:25 ` Danilo Krummrich
2026-05-18 2:12 ` SeongJae Park
2026-05-16 22:32 ` Mauro Carvalho Chehab
-- strict thread matches above, loose matches on Subject: below --
2026-05-17 19:42 Roman Gushchin
2026-05-17 22:05 ` Mauro Carvalho Chehab
2026-05-17 19:53 Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260517162912.GA51520@macsyma-wired.lan \
--to=tytso@mit.edu \
--cc=acme@kernel.org \
--cc=debarbos@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kfree@google.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mchehab+huawei@kernel.org \
--cc=mricon@kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sashiko@lists.linux.dev \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox