From: SeongJae Park <sj@kernel.org>
To: Roman Gushchin <roman.gushchin@linux.dev>
Cc: SeongJae Park <sj@kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
Konstantin Ryabitsev <mricon@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
Krzysztof Kozlowski <krzk@kernel.org>,
sashiko-bot@kernel.org, sashiko-reviews@lists.linux.dev,
sashiko@lists.linux.dev,
Linux Kernel Workflows <workflows@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org, kfree@google.com
Subject: Re: Stop false review statements
Date: Sun, 17 May 2026 19:12:58 -0700 [thread overview]
Message-ID: <20260518021300.89388-1-sj@kernel.org> (raw)
In-Reply-To: <0902F8E6-C495-40A1-975D-92D3B72D44AE@linux.dev>
On Sat, 16 May 2026 08:49:39 -0700 Roman Gushchin <roman.gushchin@linux.dev> wrote:
>
> > On May 16, 2026, at 8:45 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Sat, May 16, 2026 at 08:41:43AM -0700, Roman Gushchin wrote:
> >>
> >>>> On May 16, 2026, at 8:20 AM, Konstantin Ryabitsev <mricon@kernel.org> wrote:
> >>>
> >>> On Sat, May 16, 2026 at 05:11:28AM -0700, Guenter Roeck wrote:
> >>>>> On Sat, May 16, 2026 at 10:05:02AM +0200, Krzysztof Kozlowski wrote:
[...]
> >> The goal here is to inform maintainers that sashiko has successfully reviewed the patch
> >> and there were no findings, otherwise maintainers have to go to the web site and check the status.
Yes, this will be helpful. I also think notifying review failures (usually due
to patch applying failure) or general review results summary for every case
(maybe opt-in?) would also be helpful.
> >
> > That's fine.
> >
> >> I’m not attached to any specific form of it, I thought Reviewed-by is the most obvious form.
> >> And we use Reported-by: tags with various tooling for years.
> >
> > Reported-by: shows the existance of a problem that some tool found, a
> > subtle difference here.
> >
> >> What do you think is the best form?
> >>
> >> I’ll pause sending reviewed-by tags until we have a discussion and agreement here.
> >
> > Just say it in some other text form, that our tools will not pick up.
> > Like:
> > Tool XXXX reports that all is good:
> > https://....
> >
> > or something like that?
>
> Sure, works for me.
+1. I was also feeling Reviewed-by: is at least controversial.
Thanks,
SJ
[...]
next prev parent reply other threads:[~2026-05-18 2:13 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-16 8:05 Stop false review statements Krzysztof Kozlowski
2026-05-16 12:11 ` Guenter Roeck
2026-05-16 12:16 ` Krzysztof Kozlowski
2026-05-16 12:23 ` Guenter Roeck
2026-05-16 12:29 ` Krzysztof Kozlowski
2026-05-16 13:24 ` Laurent Pinchart
2026-05-16 13:45 ` Krzysztof Kozlowski
2026-05-16 21:10 ` Mauro Carvalho Chehab
2026-05-17 15:21 ` Jonathan Corbet
2026-05-16 15:20 ` Konstantin Ryabitsev
2026-05-16 15:36 ` Greg KH
2026-05-16 15:41 ` Roman Gushchin
2026-05-16 15:45 ` Greg KH
2026-05-16 15:49 ` Roman Gushchin
2026-05-16 18:28 ` Arnaldo Carvalho de Melo
2026-05-16 21:29 ` Derek Barbosa
2026-05-16 21:33 ` Krzysztof Kozlowski
2026-05-16 21:59 ` Roman Gushchin
2026-05-17 8:25 ` Krzysztof Kozlowski
2026-05-17 10:05 ` Mauro Carvalho Chehab
2026-05-17 10:10 ` Willy Tarreau
2026-05-17 10:12 ` Greg KH
2026-05-17 16:29 ` Theodore Tso
2026-05-17 22:22 ` Laurent Pinchart
2026-05-17 16:39 ` Mauro Carvalho Chehab
2026-05-17 17:03 ` Guenter Roeck
2026-05-17 18:17 ` Roman Gushchin
2026-05-17 18:56 ` Mauro Carvalho Chehab
2026-05-18 5:31 ` Greg KH
2026-05-17 18:57 ` Theodore Tso
2026-05-17 19:36 ` Mauro Carvalho Chehab
2026-05-16 18:28 ` Krzysztof Kozlowski
2026-05-16 18:56 ` Roman Gushchin
2026-05-16 19:00 ` Krzysztof Kozlowski
2026-05-16 19:13 ` Guenter Roeck
2026-05-16 19:25 ` Guenter Roeck
2026-05-16 19:31 ` Roman Gushchin
2026-05-16 19:15 ` Roman Gushchin
2026-05-16 20:41 ` Theodore Tso
2026-05-17 15:56 ` Danilo Krummrich
2026-05-17 21:25 ` Danilo Krummrich
2026-05-18 2:12 ` SeongJae Park [this message]
2026-05-16 22:32 ` Mauro Carvalho Chehab
-- strict thread matches above, loose matches on Subject: below --
2026-05-17 19:42 Roman Gushchin
2026-05-17 22:05 ` Mauro Carvalho Chehab
2026-05-17 19:53 Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260518021300.89388-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kfree@google.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mricon@kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sashiko@lists.linux.dev \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox