From: Jonathan Corbet <corbet@lwn.net>
To: Guenter Roeck <linux@roeck-us.net>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: sashiko-bot@kernel.org, sashiko-reviews@lists.linux.dev,
sashiko@lists.linux.dev,
Linux Kernel Workflows <workflows@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
kfree@google.com
Subject: Re: Stop false review statements
Date: Sun, 17 May 2026 09:21:45 -0600 [thread overview]
Message-ID: <877bp2m586.fsf@trenco.lwn.net> (raw)
In-Reply-To: <fd3b2ca7-4d64-4c4b-98a3-7d3285fa6826@roeck-us.net>
Guenter Roeck <linux@roeck-us.net> writes:
> On 5/16/26 05:16, Krzysztof Kozlowski wrote:
>> Quotes from the existing policy:
>>
>> 1. "By offering my Reviewed-by: tag, I state that:"
>>
>> Tool cannot use first person "I". Tool cannot "state that".
>>
>> 2. "A Reviewed-by tag is *a statement of opinion* that the patch is an
>> appropriate modification of the kernel without any remaining serious"
>>
>> Tool cannot make a statement of opinion.
>>
>> 3. "Any interested reviewer (who has done the work) can offer a
>> Reviewed-by".
>>
>> Tool is not a reviewer as a person, thus above does not grant the tool
>> permission to offer a tag.
>
> I'd like to see that explicitly spelled out. Until then it is your opinion.
So I'm the person who wrote that text. Automated review tools weren't
really on the radar at that time, so I can't argue that it expresses an
opinion either way as to whether an LLM could make such assertions.
That said, I was certainly considering *human* reviewers at the time,
and all of the people who agreed with the suggested policy were too.
Adding bots seems like a stretch to me.
I can't speak for subsystems that require Reviewed-by tags on their
commits, but I'm not sure that their maintainers would accept an
automated review as satisfying that requirement.
If we want to record this sort of processing, perhaps a tag like
"Scanned-by" would be appropriate?
jon
next prev parent reply other threads:[~2026-05-17 15:21 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-16 8:05 Stop false review statements Krzysztof Kozlowski
2026-05-16 12:11 ` Guenter Roeck
2026-05-16 12:16 ` Krzysztof Kozlowski
2026-05-16 12:23 ` Guenter Roeck
2026-05-16 12:29 ` Krzysztof Kozlowski
2026-05-16 13:24 ` Laurent Pinchart
2026-05-16 13:45 ` Krzysztof Kozlowski
2026-05-16 21:10 ` Mauro Carvalho Chehab
2026-05-17 15:21 ` Jonathan Corbet [this message]
2026-05-16 15:20 ` Konstantin Ryabitsev
2026-05-16 15:36 ` Greg KH
2026-05-16 15:41 ` Roman Gushchin
2026-05-16 15:45 ` Greg KH
2026-05-16 15:49 ` Roman Gushchin
2026-05-16 18:28 ` Arnaldo Carvalho de Melo
2026-05-16 21:29 ` Derek Barbosa
2026-05-16 21:33 ` Krzysztof Kozlowski
2026-05-16 21:59 ` Roman Gushchin
2026-05-17 8:25 ` Krzysztof Kozlowski
2026-05-17 10:05 ` Mauro Carvalho Chehab
2026-05-17 10:10 ` Willy Tarreau
2026-05-17 10:12 ` Greg KH
2026-05-17 16:29 ` Theodore Tso
2026-05-17 22:22 ` Laurent Pinchart
2026-05-17 16:39 ` Mauro Carvalho Chehab
2026-05-17 17:03 ` Guenter Roeck
2026-05-17 18:17 ` Roman Gushchin
2026-05-17 18:56 ` Mauro Carvalho Chehab
2026-05-18 5:31 ` Greg KH
2026-05-17 18:57 ` Theodore Tso
2026-05-17 19:36 ` Mauro Carvalho Chehab
2026-05-16 18:28 ` Krzysztof Kozlowski
2026-05-16 18:56 ` Roman Gushchin
2026-05-16 19:00 ` Krzysztof Kozlowski
2026-05-16 19:13 ` Guenter Roeck
2026-05-16 19:25 ` Guenter Roeck
2026-05-16 19:31 ` Roman Gushchin
2026-05-16 19:15 ` Roman Gushchin
2026-05-16 20:41 ` Theodore Tso
2026-05-17 15:56 ` Danilo Krummrich
2026-05-17 21:25 ` Danilo Krummrich
2026-05-18 2:12 ` SeongJae Park
2026-05-16 22:32 ` Mauro Carvalho Chehab
-- strict thread matches above, loose matches on Subject: below --
2026-05-17 19:42 Roman Gushchin
2026-05-17 22:05 ` Mauro Carvalho Chehab
2026-05-17 19:53 Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877bp2m586.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=kfree@google.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sashiko@lists.linux.dev \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox