Re: [PATCH v1 07/15] arm64: dts: ti: k3-am62-verdin: Add Toradex Capacitive Touch Display 7" DSI

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The ILITEK touch controller interrupt is configured for a rising edge trigger (`IRQ_TYPE_EDGE_RISING`), despite being an active-low signal (`TOUCH_INT#`).
--

commit c5a7c369552e8dfc7c50d86e7c345bdd74ec3403
Author: Vitor Soares <vitor.soares@toradex.com>

arm64: dts: ti: k3-am62-verdin: Add Toradex Capacitive Touch Display 7" DSI

This commit adds a device tree overlay for the Toradex Capacitive Touch Display
7" DSI on the Verdin DSI_1 interface. It configures the SN65DSI83 DSI-to-LVDS
bridge and the Ilitek ILI2132 capacitive touch controller.

Link: https://developer.toradex.com/hardware/accessories/displays/capacitive-touch-display-7inch-dsi
Link: https://developer.toradex.com/hardware/accessories/add-ons/dsi-display-adapter/

> diff --git a/arch/arm64/boot/dts/ti/k3-am625-verdin-panel-cap-touch-7inch-dsi.dtso b/arch/arm64/boot/dts/ti/k3-am625-verdin-panel-cap-touch-7inch-dsi.dtso
> new file mode 100644
> index 0000000000000..0fa8306324b38
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-am625-verdin-panel-cap-touch-7inch-dsi.dtso
[ ... ]
> +	touch@41 {
> +		compatible = "ilitek,ili2132";
> +		reg = <0x41>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_dsi1_int>, <&pinctrl_i2s_2_bclk_gpio>;
> +		/* Verdin GPIO_9_DSI (SODIMM 17) - TOUCH_INT# */
> +		interrupt-parent = <&main_gpio1>;
> +		interrupts = <49 IRQ_TYPE_EDGE_RISING>;

[Severity: Medium]
Is this interrupt trigger configuration correct? The comment identifies the
signal as TOUCH_INT#, where the '#' suffix conventionally denotes an active-low
signal.

Configuring the trigger as IRQ_TYPE_EDGE_RISING means the hardware interrupt
will fire when the touch controller releases the line, rather than when it
asserts it. Should this regression be addressed by configuring it as
IRQ_TYPE_EDGE_FALLING or IRQ_TYPE_LEVEL_LOW instead?

> +		/* Verdin I2S_2_BCLK (SODIMM 42) - TOUCH_RESET# */
> +		reset-gpios = <&main_gpio0 35 GPIO_ACTIVE_LOW>;
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260521150038.103538-17-ivitro@gmail.com?part=7