Re: [PATCH v1 14/15] dt-bindings: display: panel-lvds: Add LG LP156WF1

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The dt-binding fails to enforce the dual-channel requirement (the `ports` property) for the newly added `lg,lp156wf1` compatible string.
--

commit a568203d1851908daadd835b566099e0a123357a
Author: Vitor Soares <vitor.soares@toradex.com>
dt-bindings: display: panel-lvds: Add LG LP156WF1

This commit adds the compatible string for the LG LP156WF1 15.6" FHD
dual-channel TFT LCD LVDS panel to the generic panel-lvds schema.

> diff --git a/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml b/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
> index 45183a1439ce9..a6af2b9cc2f9a 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
> @@ -58,6 +58,8 @@ properties:
>            - hydis,hv070wx2-1e0
>            # Jenson Display BL-JT60050-01A 7" WSVGA (1024x600) color TFT LCD LVDS panel
>            - jenson,bl-jt60050-01a
> +          # LG LP156WF1 15.6" FHD (1920x1080) dual-channel TFT LCD LVDS panel
> +          - lg,lp156wf1

[Severity: Medium]
Since the commit message indicates this is a dual-channel panel, shouldn't we
add an if-then conditional block to require the ports property specifically for
this compatible string?

Currently, the panel-lvds.yaml schema allows panels to be configured with
either a single port or multiple ports. Without a specific conditional block
enforcing required: [ports] for lg,lp156wf1, a device tree incorrectly
configuring this dual-channel hardware with only a single port will silently
pass validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260521150038.103538-17-ivitro@gmail.com?part=14