Re: [PATCH v1 01/15] dt-bindings: display: panel: Move Logic Technologies LT170410-2WHC to LVDS

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Moving the LT170410-2WHC panel from panel-simple.yaml to panel-lvds.yaml breaks backwards compatibility and enforces unnecessary DT properties, as the panel is already supported by the panel-simple driver.
--

commit 2566a5e0031b5362bab9727f188d6fff83345dfc
Author: Vitor Soares <vitor.soares@toradex.com>

dt-bindings: display: panel: Move Logic Technologies LT170410-2WHC to LVDS

This commit moves the Logic Technologies LT170410-2WHC panel compatible
string from the panel-simple binding to the panel-lvds binding.

> diff --git a/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml b/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
> index b31c67babaa86..9db96dd724b24 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
> @@ -58,6 +58,8 @@ properties:
>            - hydis,hv070wx2-1e0
>            # Jenson Display BL-JT60050-01A 7" WSVGA (1024x600) color TFT LCD LVDS panel
>            - jenson,bl-jt60050-01a
> +          # Logic Technologies LT170410-2WHC 10.1" 1280x800 IPS TFT Cap Touch Mod.
> +          - logictechno,lt170410-2whc

[Severity: Medium]
Will this break device tree backward compatibility for existing users?

The panel-lvds.yaml schema expects the compatible string to be a two-item
array ending with the generic "panel-lvds" fallback. Existing device trees
using compatible = "logictechno,lt170410-2whc" will now fail schema
validation because they lack the fallback string.

Additionally, panel-lvds requires explicit properties like data-mapping,
width-mm, height-mm, and panel-timing to be defined in the device tree.

Since the panel-simple driver inherently supports LVDS panels and already
hardcodes the panel's configuration (timings, dimensions, etc.), is there
a reason to move it to panel-lvds and mandate these generic properties in
the device tree?

If LVDS-specific properties like data-mapping are needed, could we keep
the compatible string in panel-simple.yaml and add it to the conditional
exception list that allows data-mapping instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260521150038.103538-17-ivitro@gmail.com?part=1