Re: [PATCH v4 2/4] dt-bindings: mfd: sprd,sc2731: Include SC2730 regulator bindings

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Removing the unconditional `$ref` for the `regulators` node without adding conditionals for `sprd,sc2720`, `sprd,sc2721`, and `sprd,sc2723` leaves the `regulators` node unvalidated for those compatible strings.
--

commit 0dc1c5ed599d6def6003f8e26bf5f2c7220c8d77
Author: Otto Pflüger <otto.pflueger@abscue.de>

dt-bindings: mfd: sprd,sc2731: Include SC2730 regulator bindings

The SC2730 PMIC provides a different set of regulators from SC2731 and
requires separate regulator bindings. This commit adds conditionals for
sprd,sc2730 and sprd,sc2731 top-level compatibles to ensure the correct
regulator schemas are applied.

> diff --git a/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml b/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml
> index b023e1ef8d3cc..39d26b6ab4779 100644
> --- a/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml
> +++ b/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml
> @@ -54,7 +54,6 @@ properties:
>  
>    regulators:
>      type: object
> -    $ref: /schemas/regulator/sprd,sc2731-regulator.yaml#
>  
>  patternProperties:
>    "^adc@[0-9a-f]+$":

[ ... ]

> @@ -101,6 +100,26 @@ required:
>  
>  additionalProperties: false
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: sprd,sc2730
> +    then:
> +      properties:
> +        regulators:
> +          $ref: /schemas/regulator/sprd,sc2730-regulator.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: sprd,sc2731
> +    then:
> +      properties:
> +        regulators:
> +          $ref: /schemas/regulator/sprd,sc2731-regulator.yaml#

[Severity: Medium]
Does removing the unconditional $ref leave the regulators node unvalidated for
the older compatible strings?

The compatible enum for this schema also includes sprd,sc2720, sprd,sc2721,
and sprd,sc2723. Now that the default $ref has been removed, if one of those
older compatible strings is used, there is no conditional block that applies.

This appears to fall back to an unconstrained type: object schema for those
compatibles, which means invalid or malformed properties within the regulators
node will silently pass dt-binding checks.

Should there be an additional conditional block for these older PMICs to
ensure their regulators are fully validated?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260521-sc2730-regulators-v4-0-1ac8a3b5ed82@abscue.de?part=2