Re: [PATCH v4 3/4] mfd: sprd-sc27xx: Add SC2730 regulator cell

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The existing MFD cells for `sc2731-regulator` and `sc2731-poweroff` fail to bind to their respective drivers due to naming mismatches.
--

commit 410bda683e83be6297ddc2d59ec5df1da8471eae
Author: Otto Pflüger <otto.pflueger@abscue.de>

mfd: sprd-sc27xx: Add SC2730 regulator cell

Add an MFD cell to register the SC2730 PMIC's regulators.

> diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c
> index aa052f6466231..214bcbef0c271 100644
> --- a/drivers/mfd/sprd-sc27xx-spi.c
> +++ b/drivers/mfd/sprd-sc27xx-spi.c
> @@ -61,6 +61,7 @@ static const struct mfd_cell sc2730_devices[] = {
>  	MFD_CELL_OF("sc2730-efuse", NULL, NULL, 0, 0, "sprd,sc2730-efuse"),
>  	MFD_CELL_OF("sc2730-eic", NULL, NULL, 0, 0, "sprd,sc2730-eic"),
>  	MFD_CELL_OF("sc2730-fgu", NULL, NULL, 0, 0, "sprd,sc2730-fgu"),
> +	MFD_CELL_NAME("sc2730-regulator"),
>  	MFD_CELL_OF("sc2730-rtc", NULL, NULL, 0, 0, "sprd,sc2730-rtc"),
>  	MFD_CELL_OF("sc2730-vibrator", NULL, NULL, 0, 0, "sprd,sc2730-vibrator"),
>  };

[Severity: High]
This isn't a bug introduced by this patch, but do the existing MFD cells for
SC2731 regulators and poweroff fail to bind to their respective drivers due
to naming mismatches?

The sc2731_devices array creates MFD cells named "sc2731-regulator" and
"sc2731-poweroff". However, their corresponding platform drivers
(drivers/regulator/sc2731-regulator.c and
drivers/power/reset/sc27xx-poweroff.c) set their .name fields to
"sc27xx-regulator" and "sc27xx-poweroff", respectively.

Since neither driver provides a platform_device_id table to map the
SoC-specific names, does the platform_match() string comparison fail?

Would this leave the SC2731 hardware without regulator control and poweroff
functionality since the MFD core instantiates these platform devices, but
they never bind to their drivers?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260521-sc2730-regulators-v4-0-1ac8a3b5ed82@abscue.de?part=3