From: "Otto Pflüger" <otto.pflueger@abscue.de>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>, Lee Jones <lee@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/4] dt-bindings: mfd: sprd,sc2731: Include SC2730 regulator bindings
Date: Fri, 22 May 2026 08:32:13 +0200 [thread overview]
Message-ID: <ag_4bYWlsrpBjx3p@abscue.de> (raw)
In-Reply-To: <20260522-sweet-magic-kelpie-d6daec@quoll>
On Fri, May 22, 2026 at 08:28:59AM +0200, Krzysztof Kozlowski wrote:
> On Thu, May 21, 2026 at 06:17:07PM +0200, Otto Pflüger wrote:
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: sprd,sc2731
>
> And what about every other variant?
For sc2720, sc2721 and sc2723, the regulators should also be different,
but I'm not able to test anything with those PMICs. The original binding
was wrong.
>
> > + then:
> > + properties:
> > + regulators:
> > + $ref: /schemas/regulator/sprd,sc2731-regulator.yaml#
> > +
> > examples:
> > - |
> > #include <dt-bindings/gpio/gpio.h>
> >
> > --
> > 2.51.0
> >
next prev parent reply other threads:[~2026-05-22 6:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 16:17 [PATCH v4 0/4] regulator: Add support for Unisoc SC2730 PMIC regulators Otto Pflüger
2026-05-21 16:17 ` [PATCH v4 1/4] regulator: dt-bindings: Add Unisoc SC2730 PMIC Otto Pflüger
2026-05-22 6:14 ` Krzysztof Kozlowski
2026-05-21 16:17 ` [PATCH v4 2/4] dt-bindings: mfd: sprd,sc2731: Include SC2730 regulator bindings Otto Pflüger
2026-05-21 16:52 ` sashiko-bot
2026-05-22 6:28 ` Krzysztof Kozlowski
2026-05-22 6:32 ` Otto Pflüger [this message]
2026-05-22 7:06 ` Krzysztof Kozlowski
2026-05-21 16:17 ` [PATCH v4 3/4] mfd: sprd-sc27xx: Add SC2730 regulator cell Otto Pflüger
2026-05-21 17:33 ` sashiko-bot
2026-05-21 16:17 ` [PATCH v4 4/4] regulator: Add regulator driver for Unisoc SC2730 PMIC Otto Pflüger
2026-05-21 17:57 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ag_4bYWlsrpBjx3p@abscue.de \
--to=otto.pflueger@abscue.de \
--cc=baolin.wang@linux.alibaba.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=robh@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox