Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Shawn Guo" <shengchao.guo@oss.qualcomm.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 RESEND 3/5] arm64: dts: qcom: Add device tree for Nord SA8797P SoC
Date: Tue, 26 May 2026 06:01:46 +0000	[thread overview]
Message-ID: <20260526060147.1D1931F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260526051300.1669201-4-shengchao.guo@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message claims to configure SCMI power domains only for UART controllers, completely omitting the massive changes to dozens of I2C and SPI controllers.
--

commit 8aedf4e02d9c2b72f74522328779082b0ccb3f99
Author: Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>

arm64: dts: qcom: Add device tree for Nord SA8797P SoC

This patch adds the SoC-level device tree include for the SA8797P, an
automotive variant of the Nord SoC family. It includes reserved shared
memory regions for SCMI, QUPV3 GENI SE blocks, and a UFS host controller.
It also introduces a common SCMI include file for shared firmware channels.

>  - Three QUPV3 GENI SE QUP blocks (qupv3_0/1/2) with UART controllers
>    using SCMI power and performance domains via scmi11

[Severity: Medium]
Is this description complete?

The commit message explicitly mentions UART controllers using SCMI power
and performance domains, but the patch also configures 21 I2C controllers
and 21 SPI controllers to use the scmi11 domains.

Could the commit message be updated to accurately reflect the additions of
the I2C and SPI controllers?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260526051300.1669201-1-shengchao.guo@oss.qualcomm.com?part=3

  reply	other threads:[~2026-05-26  6:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26  5:12 [PATCH v3 RESEND 0/5] Add initial device trees for Nord SA8797P Shawn Guo
2026-05-26  5:12 ` [PATCH v3 RESEND 1/5] dt-bindings: crypto: qcom,inline-crypto-engine: Document Nord ICE Shawn Guo
2026-05-26  5:12 ` [PATCH v3 RESEND 2/5] arm64: dts: qcom: Add device tree for Nord SoC series Shawn Guo
2026-05-26  5:44   ` sashiko-bot
2026-05-26  5:12 ` [PATCH v3 RESEND 3/5] arm64: dts: qcom: Add device tree for Nord SA8797P SoC Shawn Guo
2026-05-26  6:01   ` sashiko-bot [this message]
2026-05-26  5:12 ` [PATCH v3 RESEND 4/5] dt-bindings: arm: qcom: Document SA8797P Ride board Shawn Guo
2026-05-26  6:11   ` sashiko-bot
2026-05-26  5:13 ` [PATCH v3 RESEND 5/5] arm64: dts: qcom: Add device tree for " Shawn Guo
2026-05-26  6:29   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260526060147.1D1931F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=shengchao.guo@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox