Re: [PATCH v3 RESEND 4/5] dt-bindings: arm: qcom: Document SA8797P Ride board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The compatible block for the SA8797P Ride board is inserted out of alphabetical order, breaking the established grouping of SoC families.
--

commit 4ab172bb1d1115af0854e9ac9febc931197a537f
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>

dt-bindings: arm: qcom: Document SA8797P Ride board

This commit documents the SA8797P Ride automotive-grade development
board, which is built on the SA8797P SoC (Nord series). It adds the
compatible string for the board with fallbacks to the SoC and series
compatibles.

> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 50cc18a6ec5ed..b10383ddb8991 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -303,6 +303,12 @@ properties:
>                - xiaomi,sagit
>            - const: qcom,msm8998
>  
> +      - items:
> +          - enum:
> +              - qcom,sa8797p-ride
> +          - const: qcom,sa8797p
> +          - const: qcom,nord
> +

[Severity: Low]
Does this compatible block belong further down in the file? This isn't a
bug, but the compatibles under properties are generally grouped and
sorted alphanumerically. Placing this sa prefix block after msm8998 and
before the following entries breaks the alphabetical order of the SoC
families.

>        - items:
>            - enum:
>                - 8dev,jalapeno

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260526051300.1669201-1-shengchao.guo@oss.qualcomm.com?part=4