Re: [PATCH RFC RESEND v5 1/6] firmware: meson: sm: Add video firmware loading SMC call

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The identifier `SM_LOAD_VIDEO_FW` is used in the `gxbb_chip.cmd` array but is never defined, resulting in a build failure ('undeclared identifier'). The fix is found later in the series in commit 7da77dd38d2ea56fe7b57e246847b5cd118fd85e ('firmware: meson: sm: video firmware loading via secure monitor').
--

commit 087141e411e53f403ab8bf5aa5ca58a00cc95fd4
Author: Zhentao Guo <zhentao.guo@amlogic.com>

firmware: meson: sm: Add video firmware loading SMC call

This commit adds the SM_LOAD_VIDEO_FW command to the gxbb_chip command table
to support loading video firmware.

> diff --git a/drivers/firmware/meson/meson_sm.c b/drivers/firmware/meson/meson_sm.c
> index 3ab67aaa9e5da..5da6c65d684a0 100644
> --- a/drivers/firmware/meson/meson_sm.c
> +++ b/drivers/firmware/meson/meson_sm.c
> @@ -47,6 +47,7 @@ static const struct meson_sm_chip gxbb_chip = {
>  		CMD(SM_GET_CHIP_ID,	0x82000044),
>  		CMD(SM_A1_PWRC_SET,	0x82000093),
>  		CMD(SM_A1_PWRC_GET,	0x82000095),
> +		CMD(SM_LOAD_VIDEO_FW,	0xb200000f),

[Severity: Low]
Does this code compile on its own? It appears that SM_LOAD_VIDEO_FW is used
here but is not declared yet.

While this is resolved later in the series by commit
7da77dd38d2ea56fe7b57e246847b5cd118fd85e (firmware: meson: sm: video
firmware loading via secure monitor), each patch in a series needs to
compile successfully on its own to maintain bisectability.

>  		{ /* sentinel */ },
>  	},
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260526-b4-s4-vdec-upstream-v5-0-33bc817f93f4@amlogic.com?part=1