Re: [PATCH RFC RESEND v5 2/6] firmware: meson: sm: video firmware loading via secure monitor

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch series is incorrectly ordered, separating the enum declaration of `SM_LOAD_VIDEO_FW` from its usage, which breaks `git bisect` due to a build failure.
--

commit 7da77dd38d2ea56fe7b57e246847b5cd118fd85e
Author: Zhentao Guo <zhentao.guo@amlogic.com>

firmware: meson: sm: video firmware loading via secure monitor

This commit adds the SM_LOAD_VIDEO_FW command to the secure monitor
command enum. This enables decoder drivers to load firmware through
the meson_sm interface.

> diff --git a/include/linux/firmware/meson/meson_sm.h b/include/linux/firmware/meson/meson_sm.h
> index 8eaf8922ab020..f40867a000f10 100644
> --- a/include/linux/firmware/meson/meson_sm.h
> +++ b/include/linux/firmware/meson/meson_sm.h
> @@ -14,6 +14,7 @@ enum {
>  	SM_GET_CHIP_ID,
>  	SM_A1_PWRC_SET,
>  	SM_A1_PWRC_GET,
> +	SM_LOAD_VIDEO_FW,

[Severity: Low]
Could this patch series ordering break git bisect?

The previous commit 087141e411e53 ("firmware: meson: sm: Add video firmware
loading SMC call") uses the SM_LOAD_VIDEO_FW command, but the enum value is
not declared until this subsequent commit. Checking out the previous commit
would result in an undeclared identifier compilation error. Should this
declaration be moved before its usage to maintain bisectability?

>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260526-b4-s4-vdec-upstream-v5-0-33bc817f93f4@amlogic.com?part=2