Re: [PATCH RFC RESEND v5 6/6] arm64: defconfig: Enable CONFIG_VIDEO_AMLOGIC_VDEC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] CONFIG_VIDEO_AMLOGIC_VDEC selects MESON_SM without satisfying its ARM64_4K_PAGES dependency, causing Kconfig warnings under COMPILE_TEST or when using 16K/64K pages.
- [Low] CONFIG_VIDEO_AMLOGIC_VDEC is inserted manually out of order in arm64 defconfig.
--

commit 482a11927128f3e0aa6ba1ce2517d29726af8f3b
Author: Zhentao Guo <zhentao.guo@amlogic.com>

arm64: defconfig: Enable CONFIG_VIDEO_AMLOGIC_VDEC

This commit enables the Amlogic V4L2 stateless video decoder driver as a
module in the arm64 defconfig.

> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 4567f4b34f293..14caac24d2009 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -913,6 +913,7 @@ CONFIG_V4L_PLATFORM_DRIVERS=y
>  CONFIG_SDR_PLATFORM_DRIVERS=y
>  CONFIG_V4L_MEM2MEM_DRIVERS=y
>  CONFIG_VIDEO_AMPHION_VPU=m
> +CONFIG_VIDEO_AMLOGIC_VDEC=m

[Severity: Low]
Does enabling this configuration expose a dependency issue in the driver's
Kconfig?

In the Kconfig definition for VIDEO_AMLOGIC_VDEC introduced earlier in this
patchset, it unconditionally uses select MESON_SM. However, MESON_SM has a
strict dependency on ARM64_4K_PAGES.

Selecting a symbol without meeting its dependencies forces it on, which can
trigger unmet direct dependency warnings during builds on architectures or
configurations where ARM64_4K_PAGES is not met. This can happen on non-ARM64
COMPILE_TEST builds or ARM64 builds configured with 16K or 64K pages.

Could the driver use depends on MESON_SM instead of select to avoid
breaking automated Kconfig build testing?

[Severity: Low]
This isn't a bug, but was this defconfig change generated using make
savedefconfig?

In the media platform Kconfig hierarchy, the Amlogic platform Kconfig is
included before the Amphion platform Kconfig. Running make savedefconfig
would naturally place CONFIG_VIDEO_AMLOGIC_VDEC before
CONFIG_VIDEO_AMPHION_VPU.

Manually inserting it after Amphion will cause unnecessary churn the next
time make savedefconfig is executed.

>  CONFIG_VIDEO_CADENCE_CSI2RX=m
>  CONFIG_VIDEO_WAVE_VPU=m
>  CONFIG_VIDEO_E5010_JPEG_ENC=m

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260526-b4-s4-vdec-upstream-v5-0-33bc817f93f4@amlogic.com?part=6