Re: [PATCH RFC RESEND v5 3/6] media: dt-bindings: Add Amlogic V4L2 video decoder

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The `resets` property is functionally necessary and present in the example, but it is omitted from the `required` list.
- [Low] The schema allows multiple interrupts but lacks `interrupt-names`, `items` descriptions, and a `minItems` constraint.
--

commit 4ec0f5c7e982a0f22963af0593b18e2e09373c7e
Author: Zhentao Guo <zhentao.guo@amlogic.com>

media: dt-bindings: Add Amlogic V4L2 video decoder

This commit describes the initial support for the V4L2 stateless video decoder
driver used with the Amlogic S4 (S805X2) platform.

> diff --git a/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml b/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml
> new file mode 100644
> index 0000000000000..a0f33f6c35a17
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/amlogic,s4-vdec.yaml
[ ... ]
> +properties:
> +  compatible:
> +    const: amlogic,s4-vdec
> +
> +  reg:
> +    maxItems: 2
> +
> +  reg-names:
> +    items:
> +      - const: dos
> +      - const: dmc
> +
> +  interrupts:
> +    maxItems: 3

[Severity: Low]
Should this property include an items list with descriptions or a
corresponding interrupt-names property? Without these, there is no
documentation on what each of the three interrupts represents or the
required order. 

Is a minItems constraint also needed here so that device trees with fewer
than 3 interrupts do not silently pass schema validation?

> +
> +  clocks:
> +    maxItems: 3
[ ... ]
> +  secure-monitor:
> +    description: phandle to the secure-monitor node
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +
> +required:
> +  - compatible
> +  - reg
> +  - reg-names
> +  - interrupts
> +  - clocks
> +  - clock-names
> +  - power-domains
> +  - power-domain-names
> +  - amlogic,canvas
> +  - secure-monitor

[Severity: Medium]
Should resets be included in this required list? It is defined in the
properties block and explicitly used in the device tree example below.

Omitting it here might allow incompletely configured device tree nodes missing
the reset line to silently pass schema validation, which could lead to driver
initialization failures or undefined hardware states at runtime.

> +
> +additionalProperties: false
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260526-b4-s4-vdec-upstream-v5-0-33bc817f93f4@amlogic.com?part=3