Re: [PATCH v3 02/13] spi: dt-bindings: cdns,qspi-nor: add PHY tuning pattern partition property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `cdns,phy-pattern-partition` property references a software MTD partition via phandle, mixing software layout with hardware description.
--

commit febb42c38a1be5c88fbbc4e7b590710091550313
Author: Santhosh Kumar K <s-k6@ti.com>

spi: dt-bindings: cdns,qspi-nor: add PHY tuning pattern partition property

This commit introduces a new property, cdns,phy-pattern-partition, which
provides a phandle to the flash partition holding the PHY tuning pattern.
This allows the controller to locate the tuning data directly during
calibration rather than searching through partitions by label.

> diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor-peripheral-props.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor-peripheral-props.yaml
> index 510b82c177c05..0ffcdf5b00d03 100644
> --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor-peripheral-props.yaml
> +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor-peripheral-props.yaml
> @@ -39,4 +39,12 @@ properties:
>        Delay in nanoseconds between setting qspi_n_ss_out low and
>        first bit transfer.
>  
> +  cdns,phy-pattern-partition:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      Phandle to the flash partition containing the PHY tuning pattern.

[Severity: Medium]
Does this mix software layout abstractions with the hardware description?

Device Tree is intended to describe hardware topology, but MTD partitions
are a software partitioning scheme. Referencing a software partition node
directly from a hardware controller property tightly couples the hardware
configuration to a software concept.

If the standard NVMEM framework is unsuitable here because the SPI
controller requires a raw physical offset to issue hardware read commands,
would it be more appropriate to define a simple hardware-level property
like cdns,phy-pattern-offset instead of relying on partition phandles?

> +      When present, the controller uses this partition to locate the
> +      pattern data during PHY tuning instead of searching all partitions
> +      by label.
> +
>  additionalProperties: true

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260527175527.2247679-1-s-k6@ti.com?part=2