Re: [PATCH v3 01/13] spi: dt-bindings: allow spi-max-frequency to specify a frequency pair

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Schema Validation Regression: Changing `spi-max-frequency` global type to `uint32-array` silently disables bounds checking on existing peripheral bindings.
--

commit 165130603fd7c72c188dc391a534397b6c57dbd4
Author: Santhosh Kumar K <s-k6@ti.com>

spi: dt-bindings: allow spi-max-frequency to specify a frequency pair

This commit extends the spi-max-frequency property to accept either a single
maximum frequency or a two-element array. The array format allows specifying
a conservative base frequency alongside a higher speed that is supported
after controller-side configurations.

> diff --git a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml
> --- a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml
[ ... ]
>    spi-max-frequency:
> -    $ref: /schemas/types.yaml#/definitions/uint32
> +    $ref: /schemas/types.yaml#/definitions/uint32-array

[Severity: High]
Does changing the global definition to uint32-array cause issues for existing
peripheral schemas that constrain this property using the maximum keyword?

According to the JSON schema specifications, the maximum keyword applies only
to numeric instances. When the instance is changed to an array, the maximum
constraint is silently ignored. 

If existing device bindings constrain this directly using maximum (for
example, maximum: 10000000 without wrapping it in an items object), will
they silently fail to validate bounds and allow out-of-spec device tree
values to pass validation?

> +    minItems: 1
> +    maxItems: 2
>      description:
> -      Maximum SPI clocking speed of the device in Hz.
> +      SPI clocking speed of the device in Hz. Either a single maximum

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260527175527.2247679-1-s-k6@ti.com?part=1