Re: [PATCH v2 1/3] dt-bindings: clock: qcom,lcc: add MSM8x60 family compatibles

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing overarching schema updates in `qcom-soc.yaml` for legacy-formatted compatible strings.
--

commit 5610427121060301089bb1b2b018a18be452795c
Author: Herman van Hazendonk <github.com@herrie.org>

dt-bindings: clock: qcom,lcc: add MSM8x60 family compatibles

This patch adds MSM8x60 family compatibles to the qcom,lcc dt-bindings schema.
It includes them in the main enum and the existing parent-clock-name
conditional block that already covers apq8064 and msm8960.

> diff --git a/Documentation/devicetree/bindings/clock/qcom,lcc.yaml b/Documentation/devicetree/bindings/clock/qcom,lcc.yaml
> index 55985e562a34f..bbdad157f03fe 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,lcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,lcc.yaml
> @@ -12,9 +12,12 @@ maintainers:
>  properties:
>    compatible:
>      enum:
> +      - qcom,lcc-apq8060
>        - qcom,lcc-apq8064
>        - qcom,lcc-ipq8064
>        - qcom,lcc-mdm9615
> +      - qcom,lcc-msm8260
> +      - qcom,lcc-msm8660
>        - qcom,lcc-msm8960

[Severity: Low]
Does Documentation/devicetree/bindings/arm/qcom-soc.yaml also need to be
updated to include these new compatibles?

Because these new compatibles use the legacy qcom,<ip>-<soc> format, they
fail the preferred pattern validation in qcom-soc.yaml. Usually, legacy
formatted strings are whitelisted in the overarching qcom-soc.yaml schema
under properties/compatible/oneOf/enum, where qcom,lcc-msm8960 and others
currently reside:

Documentation/devicetree/bindings/arm/qcom-soc.yaml:
      - enum:
          - qcom,dsi-ctrl-6g-qcm2290
          - qcom,gpucc-sdm630
          - qcom,gpucc-sdm660
          - qcom,lcc-apq8064
          - qcom,lcc-ipq8064
          - qcom,lcc-mdm9615
          - qcom,lcc-msm8960

Will omitting them from this whitelist cause dtbs_check validation to fail
when evaluating board device trees?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1780197511.git.github.com@herrie.org?part=1