Re: [PATCH v2 2/3] dt-bindings: clock: qcom: add lcc-msm8660 LPASS clock IDs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new `qcom,lcc-msm8660`, `qcom,lcc-msm8260`, and `qcom,lcc-apq8060` compatibles were not added to the legacy naming enumerations in `qcom-soc.yaml`.
--

commit f40b14d3bc25d211dba1f4b6ea323fcbe8e84acb
Author: Herman van Hazendonk <github.com@herrie.org>

dt-bindings: clock: qcom: add lcc-msm8660 LPASS clock IDs

Add the dt-binding clock-ID header for the MSM8x60 family
(MSM8260/MSM8660/APQ8060) Low Power Audio SubSystem Clock Controller
(LCC). It mirrors the format and ID range of the existing LCC headers
for newer Qualcomm SoCs.

> diff --git a/include/dt-bindings/clock/qcom,lcc-msm8660.h b/include/dt-bindings/clock/qcom,lcc-msm8660.h
> new file mode 100644
> index 0000000000000..d5d9b0d71a78f
> --- /dev/null
> +++ b/include/dt-bindings/clock/qcom,lcc-msm8660.h
> @@ -0,0 +1,48 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +/*
> + * Copyright (c) 2014, The Linux Foundation. All rights reserved.
> + */
> +
> +#ifndef _DT_BINDINGS_CLK_LCC_MSM8660_H
> +#define _DT_BINDINGS_CLK_LCC_MSM8660_H
> +
> +/*
> + * MSM8x60 family (MSM8260/MSM8660/APQ8060) LPASS Clock Controller (LCC)
> + * clock IDs. These are compatible with MSM8960 LCC as MSM8x60 and
> + * MSM8960 share the same audio subsystem clock architecture.
> + */

[Severity: Low]
Since this series introduces new compatibles for the MSM8x60 family
(qcom,lcc-msm8660, qcom,lcc-msm8260, and qcom,lcc-apq8060), do these
legacy format strings also need to be added to the generic SoC naming
constraints allowlist?

Without adding them to Documentation/devicetree/bindings/arm/qcom-soc.yaml,
will device tree schema validation fail for boards using them? They match
the generic regex but aren't in the legacy permitted list:

Documentation/devicetree/bindings/arm/qcom-soc.yaml:
      - enum:
          - qcom,dsi-ctrl-6g-qcm2290
          - qcom,gpucc-sdm630
          - qcom,gpucc-sdm660
          - qcom,lcc-apq8064
          - qcom,lcc-ipq8064
          - qcom,lcc-mdm9615
          - qcom,lcc-msm8960

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1780197511.git.github.com@herrie.org?part=2