Re: [PATCH v1 05/10] ARM: tegra: tf701t: Add thermal zones for nct1008 sensor

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The trip point label `skip_alert_trip` and cooling map node `map-skip` use 'skip' instead of 'skin', which is inconsistent with the node name and context.
--

commit d0ffa943912777c608b0f811f5bcfceeb964f099
Author: Svyatoslav Ryhel <clamor95@gmail.com>

ARM: tegra: tf701t: Add thermal zones for nct1008 sensor

This commit adds thermal zones for the NCT72 sensor in the ASUS TF701T to
provide more accurate temperature readings for both the skin and CPU.

> diff --git a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> --- a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> +++ b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
[ ... ]
> +		nct72-skin-thermal {
> +			polling-delay-passive = <1000>; /* milliseconds */
> +			polling-delay = <5000>; /* milliseconds */
> +
> +			thermal-sensors = <&temp_sensor 0>;
> +
> +			trips {
> +				skip_alert_trip: skin-alert {

[Severity: Low]
This isn't a bug, but is skip_alert_trip a typo? Given the zone is named
nct72-skin-thermal and the trip is skin-alert, it looks like this should
probably be skin_alert_trip.

> +					/* throttle at 57C until temperature drops to 56.5C */
> +					temperature = <57000>;
> +					hysteresis = <500>;
> +					type = "passive";
> +				};
> +
> +				skin-crit {
> +					/* shut down at 65C */
> +					temperature = <65000>;
> +					hysteresis = <2000>;
> +					type = "critical";
> +				};
> +			};
> +
> +			cooling-maps {
> +				map-skip {

[Severity: Low]
This isn't a bug, but similarly, should map-skip be named map-skin instead
to match the rest of the skin thermal zone naming?

> +					trip = <&skip_alert_trip>;
> +					cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +							 <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +							 <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +							 <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> +				};
> +			};
> +		};
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260604065556.137614-1-clamor95@gmail.com?part=5