Re: [PATCH v1 07/10] ARM: tegra: tf701t: Fix BCM4334 configuration

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch silently changes the WiFi node's compatible string to include 'brcm,bcm43340-fmac', which contradicts the commit message stating it fixes 'BCM4334' configuration.
--

commit e6b9085d18e1ff9ab5d22d698abaaba30676ee22
Author: Svyatoslav Ryhel <clamor95@gmail.com>

ARM: tegra: tf701t: Fix BCM4334 configuration

This commit removes the reset GPIO from the Bluetooth node and adds the
lpo clock to both the WiFi and Bluetooth nodes to fix configuration.

> diff --git a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> index 73276f2aa7fe4..e3e0b4ba7eb86 100644
> --- a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> +++ b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts

[ ... ]

> @@ -2382,9 +2382,12 @@ mmc@78000000 {
>  		vqmmc-supply = <&vdd_1v8_vio>;
>  
>  		wifi@1 {
> -			compatible = "brcm,bcm4329-fmac";
> +			compatible = "brcm,bcm43340-fmac", "brcm,bcm4329-fmac";

[Severity: Medium]
The commit message notes this fixes BCM4334 configuration, and explicitly
mentions dropping a GPIO and adding an lpo clock, but it does not mention
modifying the compatible string.

Could the commit message be updated to document this change? Also, is
brcm,bcm43340-fmac the correct value here, or is it a typo for
brcm,bcm4334-fmac, given the commit title and the Bluetooth node both
specify BCM4334?

>  			reg = <1>;
>  
> +			clocks = <&palmas_clk32k>;
> +			clock-names = "lpo";
> +
>  			interrupt-parent = <&gpio>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260604065556.137614-1-clamor95@gmail.com?part=7