Re: [PATCH v1 01/10] ARM: tegra: tf701t: Configure CPU DFLL clock node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Undocumented property `vdd-cpu-supply` in the CPU node causes DT schema validation error.
--

commit 6008fcd28f85175352ead4c8b62a3dd577cf2865
Author: Svyatoslav Ryhel <clamor95@gmail.com>

ARM: tegra: tf701t: Configure CPU DFLL clock node
    
Enable DFLL for ASUS TF701T since it is now supported by Tegra114.

> diff --git a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> index f02e2cf65fe82..041ea6e06531a 100644
> --- a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> +++ b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts

[ ... ]

> @@ -1752,6 +1760,12 @@ connector_in: endpoint {
>  		};
>  	};
>  
> +	cpus {
> +		cpu@0 {
> +			vdd-cpu-supply = <&vdd_cpu>;
                        ^^^^^^^^^^^^^^

[Severity: Low]
Will adding vdd-cpu-supply to the cpu@0 node introduce a regression by
triggering a dtbs_check schema validation error?

The device tree binding for ARM CPUs in
Documentation/devicetree/bindings/arm/cpus.yaml specifies
unevaluatedProperties: false and does not define or allow the vdd-cpu-supply
property.

Is this property ignored by the kernel when placed in the CPU node?

The Tegra DFLL clock driver reads vdd-cpu-supply exclusively from its own
clock node, and cpufreq-dt checks for cpu-supply or cpu0-supply instead.
Removing this assignment in cpu@0 might prevent a schema regression without
affecting kernel functionality.

> +		};
> +	};
> +
>  	extcon-keys {
>  		compatible = "gpio-keys";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260604065556.137614-1-clamor95@gmail.com?part=1