Devicetree
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Michael Ellerman <mpe@kernel.org>
Cc: Conor Dooley <conor@kernel.org>, Joel Stanley <joel@jms.id.au>,
	Paul Walmsley <pjw@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>,
	Anup Patel <anup@brainfault.org>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Nicholas Piggin <npiggin@gmail.com>,
	Drew Fustini <fustini@kernel.org>,
	linux-riscv@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 7/7] riscv: dts: tenstorrent: Add Atlantis platform
Date: Fri, 5 Jun 2026 15:31:06 -0500	[thread overview]
Message-ID: <20260605203106.GA98957-robh@kernel.org> (raw)
In-Reply-To: <f3fd53dc-7010-4b3d-a33c-4d1d32d3a1a6@kernel.org>

On Sat, Jun 06, 2026 at 12:02:41AM +1000, Michael Ellerman wrote:
> On 5/6/26 2:47 am, Conor Dooley wrote:
> > On Fri, Jun 05, 2026 at 12:09:53AM +0930, Joel Stanley wrote:
> > > Add initial support for the Tenstorrent Atlantis platform, based on the
> > > Atlantis SoC featuring 8x RVA23-compliant Tenstorrent Ascalon-XG cores.
> > > 
> > > The evb machine represents an internal bringup vehicle with just the
> > > interrupt controllers and a UART. This will be replaced in time with a
> > > full featured machine once details are available.
> ...
> > > diff --git a/arch/riscv/boot/dts/tenstorrent/atlantis-evb.dts b/arch/riscv/boot/dts/tenstorrent/atlantis-evb.dts
> > > new file mode 100644
> > > index 000000000000..06259cca8357
> > > --- /dev/null
> > > +++ b/arch/riscv/boot/dts/tenstorrent/atlantis-evb.dts
> > > @@ -0,0 +1,33 @@
> > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > > +/dts-v1/;
> > > +
> > > +#include "atlantis-soc.dtsi"
> > > +
> > > +/ {
> > > +	model = "Tenstorrent Atlantis development platform";
> > > +	compatible = "tenstorrent,atlantis-evb", "tenstorrent,atlantis";
> > > +
> > > +	#address-cells = <2>;
> > > +	#size-cells = <2>;
> > > +
> > > +	memory@0 {
> > > +		device_type = "memory";
> > > +		reg = <0x0 0x00000000 0x0 0x80000000>,
> > > +		      <0x1 0x80000000 0x0 0x80000000>;
> > > +	};
> > > +
> > > +	aliases {
> > > +		serial0 = &uart1;
> > > +	};
> > > +
> > > +	chosen {
> > > +		bootargs = "earlycon console=ttyS0";
> > 
> > FYI, this should not be in here.
> 
> It should be there if you want a working console :)
> 
> I know it's a "rule" to not include bootargs, but this system has no boot
> loader, so not setting bootargs just means the DTS is no use to anyone.

'console' is redundant as 'stdout-path' is set.

'earlycon' is only needed if you don't boot to the regular UART console. 
I would hope by default this system boots all the way.

> 
> > > +		stdout-path = "serial0";


Rob

  parent reply	other threads:[~2026-06-05 20:31 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-04 14:39 [PATCH v2 0/7] riscv: dts: tenstorrent: Add Atlantis platform Joel Stanley
2026-06-04 14:39 ` [PATCH v2 1/7] dt-bindings: aplic: Add Tenstorrent Atlantis compatible Joel Stanley
2026-06-05 19:54   ` Drew Fustini
2026-06-04 14:39 ` [PATCH v2 2/7] dt-bindings: imsics: " Joel Stanley
2026-06-04 16:44   ` Conor Dooley
2026-06-05 19:54   ` Drew Fustini
2026-06-04 14:39 ` [PATCH v2 3/7] dt-bindings: riscv: cpus: Add Tenstorrent Ascalon Joel Stanley
2026-06-04 16:44   ` Conor Dooley
2026-06-05 19:56   ` Drew Fustini
2026-06-04 14:39 ` [PATCH v2 4/7] dt-bindings: timer: Add RISC-V ACLINT mtimer bindings Joel Stanley
2026-06-04 14:51   ` sashiko-bot
2026-06-04 16:43   ` Conor Dooley
2026-06-04 14:39 ` [PATCH v2 5/7] dt-bindings: riscv: add Smrnmi extension description Joel Stanley
2026-06-04 14:39 ` [PATCH v2 6/7] dt-bindings: riscv: Add Tenstorrent Atlantis platform Joel Stanley
2026-06-04 16:43   ` Conor Dooley
2026-06-05 19:55   ` Drew Fustini
2026-06-04 14:39 ` [PATCH v2 7/7] riscv: dts: tenstorrent: Add " Joel Stanley
2026-06-04 14:50   ` sashiko-bot
2026-06-04 16:47   ` Conor Dooley
2026-06-05 14:02     ` Michael Ellerman
2026-06-05 15:41       ` Conor Dooley
2026-06-05 20:31       ` Rob Herring [this message]
2026-06-05  3:15   ` Anirudh Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260605203106.GA98957-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=anup@brainfault.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=asrinivasan@oss.tenstorrent.com \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fustini@kernel.org \
    --cc=joel@jms.id.au \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mpe@kernel.org \
    --cc=npiggin@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox