Re: [PATCH v5 13/15] ASoC: msm8916-wcd-analog: add pm8950 codec

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Interrupts are requested before their dependencies are initialized, leading to a NULL pointer dereference if an interrupt fires early.
--

(Due to recitation restrictions, I cannot quote the patch directly. Here is a free-form summary of the review findings based on the provided commit.)

commit 6bdf31b5b0e7905983f34bd3546744e90b15273e
Author: Adam Skladowski <a39.skl@gmail.com>

ASoC: msm8916-wcd-analog: add pm8950 codec

This commit adds register overrides for the PM8950 codec. It also implements
matching register overrides via the compatible string array.

[Severity: High]
This isn't a bug introduced by this patch, but could this pre-existing setup
cause a NULL pointer dereference if an interrupt fires early?

In pm8916_wcd_analog_spmi_probe(), threaded IRQs (such as
pm8916_mbhc_switch_irq_handler and mbhc_btn_press_irq_handler) are requested
via devm_request_threaded_irq(). This enables the interrupts immediately.
However, the ASoC component (priv->component) isn't initialized until much
later in pm8916_wcd_analog_probe() during ASoC sound card binding.

If the interrupt fires before the component probe, the IRQ handler executes
with a NULL priv->component:

pm8916_mbhc_switch_irq_handler()
    struct snd_soc_component *component = priv->component;
    if (snd_soc_component_read(component, CDC_A_MBHC_DET_CTL_1) ...

Passing this NULL component pointer to snd_soc_component_read() looks like
it would cause a crash. Should the IRQ registration be deferred to the
component probe, or kept disabled until the component is fully initialized?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260609162255.31074-1-mailingradian@gmail.com?part=13