* [PATCH 1/2] dt-bindings: soc: sophgo: add Milk-V Duo 256M board @ 2026-06-10 11:11 Chen-Yu Yeh 2026-06-10 11:11 ` [PATCH 2/2] riscv: dts: sophgo: Add Milk-V Duo 256M board support Chen-Yu Yeh 0 siblings, 1 reply; 3+ messages in thread From: Chen-Yu Yeh @ 2026-06-10 11:11 UTC (permalink / raw) To: unicorn_wang, inochiama Cc: Chen-Yu Yeh, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alexander Sverdlin, Han Gao, Chao Wei, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list:SOPHGO DEVICETREES and DRIVERS, open list Add compatible string for the Milk-V Duo 256M board. Signed-off-by: Chen-Yu Yeh <chenyou910331@gmail.com> --- Documentation/devicetree/bindings/soc/sophgo/sophgo.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/soc/sophgo/sophgo.yaml b/Documentation/devicetree/bindings/soc/sophgo/sophgo.yaml index 1c502618de51..fcb1d905da7d 100644 --- a/Documentation/devicetree/bindings/soc/sophgo/sophgo.yaml +++ b/Documentation/devicetree/bindings/soc/sophgo/sophgo.yaml @@ -31,6 +31,10 @@ properties: - milkv,duo-module-01-evb - const: milkv,duo-module-01 - const: sophgo,sg2000 + - items: + - enum: + - milkv,duo256m + - const: sophgo,sg2002 - items: - enum: - sipeed,licheerv-nano-b -- 2.43.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] riscv: dts: sophgo: Add Milk-V Duo 256M board support 2026-06-10 11:11 [PATCH 1/2] dt-bindings: soc: sophgo: add Milk-V Duo 256M board Chen-Yu Yeh @ 2026-06-10 11:11 ` Chen-Yu Yeh 2026-06-10 11:19 ` sashiko-bot 0 siblings, 1 reply; 3+ messages in thread From: Chen-Yu Yeh @ 2026-06-10 11:11 UTC (permalink / raw) To: unicorn_wang, inochiama Cc: Chen-Yu Yeh, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Han Gao, Nutty Liu, Longbin Li, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list:SOPHGO DEVICETREES and DRIVERS, open list:RISC-V ARCHITECTURE, open list The Milk-V Duo 256M is a small form factor development board based on the Sophgo SG2002 SoC. This patch adds basic device tree support for the board, including: - UART console - SD/MMC controller - USB host - Onboard blue status LED (connected to PWR_GPIO[2] / porte 2) Tested on actual Milk-V Duo 256M hardware, verified boot to shell and heartbeat LED functionality. Signed-off-by: Chen-Yu Yeh <chenyou910331@gmail.com> --- arch/riscv/boot/dts/sophgo/Makefile | 2 + .../boot/dts/sophgo/sg2002-milkv-duo256m.dts | 119 ++++++++++++++++++ 2 files changed, 121 insertions(+) create mode 100644 arch/riscv/boot/dts/sophgo/sg2002-milkv-duo256m.dts diff --git a/arch/riscv/boot/dts/sophgo/Makefile b/arch/riscv/boot/dts/sophgo/Makefile index 6f65526d4193..e49c8233ae1f 100644 --- a/arch/riscv/boot/dts/sophgo/Makefile +++ b/arch/riscv/boot/dts/sophgo/Makefile @@ -2,7 +2,9 @@ dtb-$(CONFIG_ARCH_SOPHGO) += cv1800b-milkv-duo.dtb dtb-$(CONFIG_ARCH_SOPHGO) += cv1812h-huashan-pi.dtb dtb-$(CONFIG_ARCH_SOPHGO) += sg2002-licheerv-nano-b.dtb +dtb-$(CONFIG_ARCH_SOPHGO) += sg2002-milkv-duo256m.dtb dtb-$(CONFIG_ARCH_SOPHGO) += sg2042-milkv-pioneer.dtb dtb-$(CONFIG_ARCH_SOPHGO) += sg2042-evb-v1.dtb dtb-$(CONFIG_ARCH_SOPHGO) += sg2042-evb-v2.dtb dtb-$(CONFIG_ARCH_SOPHGO) += sg2044-sophgo-srd3-10.dtb + diff --git a/arch/riscv/boot/dts/sophgo/sg2002-milkv-duo256m.dts b/arch/riscv/boot/dts/sophgo/sg2002-milkv-duo256m.dts new file mode 100644 index 000000000000..882fba441396 --- /dev/null +++ b/arch/riscv/boot/dts/sophgo/sg2002-milkv-duo256m.dts @@ -0,0 +1,119 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright (C) 2023 Jisheng Zhang <jszhang@kernel.org> + */ + +/dts-v1/; + +#include "sg2002.dtsi" +#include <dt-bindings/gpio/gpio.h> + +/ { + model = "Milk-V Duo 256M"; + compatible = "milkv,duo256m", "sophgo,sg2002"; + + aliases { + serial0 = &uart0; + serial1 = &uart1; + serial2 = &uart2; + serial3 = &uart3; + serial4 = &uart4; + }; + + chosen { + stdout-path = "serial0:115200n8"; + }; + + leds { + compatible = "gpio-leds"; + + led-blue { + label = "milkv:blue:status"; + gpios = <&porte 2 GPIO_ACTIVE_HIGH>; + linux,default-trigger = "heartbeat"; + default-state = "on"; + }; + }; + + reserved-memory { + #address-cells = <1>; + #size-cells = <1>; + ranges; + + coprocessor_rtos: region@83f40000 { + reg = <0x83f40000 0xc0000>; + no-map; + }; + }; +}; + +&osc { + clock-frequency = <25000000>; +}; + +&pinctrl { + uart0_cfg: uart0-cfg { + uart0-pins { + pinmux = <PINMUX(PIN_UART0_TX, 0)>, + <PINMUX(PIN_UART0_RX, 0)>; + bias-pull-up; + drive-strength-microamp = <10800>; + power-source = <3300>; + }; + }; + + sdhci0_cfg: sdhci0-cfg { + sdhci0-clk-pins { + pinmux = <PINMUX(PIN_SD0_CLK, 0)>; + bias-pull-up; + drive-strength-microamp = <16100>; + power-source = <3300>; + }; + + sdhci0-cmd-pins { + pinmux = <PINMUX(PIN_SD0_CMD, 0)>; + bias-pull-up; + drive-strength-microamp = <10800>; + power-source = <3300>; + }; + + sdhci0-data-pins { + pinmux = <PINMUX(PIN_SD0_D0, 0)>, + <PINMUX(PIN_SD0_D1, 0)>, + <PINMUX(PIN_SD0_D2, 0)>, + <PINMUX(PIN_SD0_D3, 0)>; + bias-pull-up; + drive-strength-microamp = <10800>; + power-source = <3300>; + }; + + sdhci0-cd-pins { + pinmux = <PINMUX(PIN_SD0_CD, 0)>; + bias-pull-up; + drive-strength-microamp = <10800>; + power-source = <3300>; + }; + }; +}; + +&sdhci0 { + pinctrl-0 = <&sdhci0_cfg>; + pinctrl-names = "default"; + status = "okay"; + bus-width = <4>; + no-1-8-v; + no-mmc; + no-sdio; + disable-wp; +}; + +&uart0 { + pinctrl-0 = <&uart0_cfg>; + pinctrl-names = "default"; + status = "okay"; +}; + +&usb { + dr_mode = "host"; + status = "okay"; +}; -- 2.43.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] riscv: dts: sophgo: Add Milk-V Duo 256M board support 2026-06-10 11:11 ` [PATCH 2/2] riscv: dts: sophgo: Add Milk-V Duo 256M board support Chen-Yu Yeh @ 2026-06-10 11:19 ` sashiko-bot 0 siblings, 0 replies; 3+ messages in thread From: sashiko-bot @ 2026-06-10 11:19 UTC (permalink / raw) To: Chen-Yu Yeh; +Cc: devicetree, robh, conor+dt Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider: - [Low] The device tree references a non-existent `&porte` phandle, which will cause a fatal `dtc` compilation error. - [Low] The device tree references a non-existent `&usb` phandle, which will cause a fatal `dtc` compilation error. - [Low] An unnecessary trailing blank line is added to the Makefile. -- commit 789d472cb56d573e2ba1106b883551407093dd43 Author: Chen-Yu Yeh <chenyou910331@gmail.com> riscv: dts: sophgo: Add Milk-V Duo 256M board support This commit adds basic device tree support for the Milk-V Duo 256M board, based on the Sophgo SG2002 SoC. It configures the UART console, SD/MMC controller, USB host, and a status LED. > diff --git a/arch/riscv/boot/dts/sophgo/Makefile b/arch/riscv/boot/dts/sophgo/Makefile > index 6f65526d4193b..e49c8233ae1ff 100644 > --- a/arch/riscv/boot/dts/sophgo/Makefile > +++ b/arch/riscv/boot/dts/sophgo/Makefile [ ... ] > @@ -2,7 +2,9 @@ > dtb-$(CONFIG_ARCH_SOPHGO) += cv1800b-milkv-duo.dtb > dtb-$(CONFIG_ARCH_SOPHGO) += cv1812h-huashan-pi.dtb > dtb-$(CONFIG_ARCH_SOPHGO) += sg2002-licheerv-nano-b.dtb > +dtb-$(CONFIG_ARCH_SOPHGO) += sg2002-milkv-duo256m.dtb > dtb-$(CONFIG_ARCH_SOPHGO) += sg2042-milkv-pioneer.dtb > dtb-$(CONFIG_ARCH_SOPHGO) += sg2042-evb-v1.dtb > dtb-$(CONFIG_ARCH_SOPHGO) += sg2042-evb-v2.dtb > dtb-$(CONFIG_ARCH_SOPHGO) += sg2044-sophgo-srd3-10.dtb > + [Severity: Low] This isn't a bug, but is this trailing blank line intended? It adds unnecessary whitespace at the end of the Makefile. > diff --git a/arch/riscv/boot/dts/sophgo/sg2002-milkv-duo256m.dts b/arch/riscv/boot/dts/sophgo/sg2002-milkv-duo256m.dts > new file mode 100644 > index 0000000000000..882fba441396b > --- /dev/null > +++ b/arch/riscv/boot/dts/sophgo/sg2002-milkv-duo256m.dts [ ... ] > + leds { > + compatible = "gpio-leds"; > + > + led-blue { > + label = "milkv:blue:status"; > + gpios = <&porte 2 GPIO_ACTIVE_HIGH>; [Severity: Low] Will this compile successfully? It appears the porte phandle is not yet defined in the parent dtsi files, which would cause a fatal dtc compilation error. [ ... ] > +&uart0 { > + pinctrl-0 = <&uart0_cfg>; > + pinctrl-names = "default"; > + status = "okay"; > +}; > + > +&usb { > + dr_mode = "host"; > + status = "okay"; > +}; [Severity: Low] Similar to the porte phandle above, is the usb label defined in the parent SoC dtsi files? Overriding an undefined label will also cause a dtc build failure. -- Sashiko AI review · https://sashiko.dev/#/patchset/20260610111136.1514155-1-chenyou910331@gmail.com?part=2 ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-10 11:19 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-06-10 11:11 [PATCH 1/2] dt-bindings: soc: sophgo: add Milk-V Duo 256M board Chen-Yu Yeh 2026-06-10 11:11 ` [PATCH 2/2] riscv: dts: sophgo: Add Milk-V Duo 256M board support Chen-Yu Yeh 2026-06-10 11:19 ` sashiko-bot
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox