Re: [PATCH v3 1/2] dt-bindings: iio: dac: Add AD5529R

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 974 bytes --]

On Wed, Jun 24, 2026 at 05:32:26PM +0100, Conor Dooley wrote:

> >     dac@0 {
> >         compatible = "adi,ad5529r-16";
> >         reg = <0>;
> >         adi,device-addrs = <0 1>;
> 
> I think this should be put in the channel itself and made generic.

I guess I should expand on that, putting it in the channel means it's
not tied to some device-specific knowledge about when each device
address is used.
It should be generic because there are at least 3 devices, from 2
different vendors, that we know of, using the exact same scheme.

> >         reset-gpios = <&gpio0 87 GPIO_ACTIVE_LOW>;
> >         vdd-supply  = <&vdd_reg>;
> >         hvdd-supply = <&hvdd_reg>;
> > 
> >         channel@0  { reg = <0>;  adi,output-range-microvolt = <0 5000000>; };
> >         channel@16 { reg = <16>; adi,output-range-microvolt = <0 40000000>; };
> >     };
> > 
> > Does this look reasonable to everyone?
> > 
> > Regards,
> > Janani Sunil
> > 



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]