Re: [PATCH v7 04/17] iio: add IIO_FREQUENCY channel type

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added IIO_FREQUENCY channel type lacks sysfs ABI documentation for its standard base attributes (e.g., `in_frequencyY_raw` or `out_frequencyY_raw`).
--

--- Patch [4]: [PATCH v7 04/17] iio: add IIO_FREQUENCY channel type ---
commit 7195506587746d2a02e7173a31fe7aaf67096665
Author: Rodrigo Alencar <rodrigo.alencar@analog.com>

iio: add IIO_FREQUENCY channel type

This commit adds the IIO_FREQUENCY channel type to the IIO framework to
support Direct Digital Synthesizer (DDS) devices. It updates the channel
type name specifications and event monitoring tools accordingly.

> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index bdf3d4c063317..a45277bc5d994 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -99,6 +99,7 @@ static const char * const iio_chan_type_name_spec[] = {
>  	[IIO_ATTENTION] = "attention",
>  	[IIO_ALTCURRENT] = "altcurrent",
>  	[IIO_COVERAGE] = "coverage",
> +	[IIO_FREQUENCY] = "frequency",
>  };

[Severity: Low]
Does Documentation/ABI/testing/sysfs-bus-iio need to be updated to document
this new channel type?

The IIO_FREQUENCY channel type appears to lack sysfs ABI documentation for its
standard base attributes (e.g., in_frequencyY_raw or out_frequencyY_raw),
which leaves the expected base units (e.g., Hz) and precise sysfs naming
conventions undefined.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260707-ad9910-iio-driver-v7-0-a4ec30f63700@analog.com?part=4