Re: [PATCH v7 07/17] iio: test: add kunit tests for channel prefix naming generation

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Building with CONFIG_IIO=y and CONFIG_KUNIT=m leads to an undefined reference linker error for KUnit symbols.
--

--- Patch [7]: [PATCH v7 07/17] iio: test: add kunit tests for channel prefix naming generation ---
commit 4ac1b309df3245543c36117b12d35f78434a6e33
Author: Rodrigo Alencar <rodrigo.alencar@analog.com>

iio: test: add kunit tests for channel prefix naming generation

Add a KUnit test suite covering __iio_chan_prefix_emit(), the helper
that builds IIO sysfs attribute name prefixes from an iio_chan_spec.

> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index ecc69adf61de8..78a3c27d17a1b 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
[ ... ]
> @@ -2232,6 +2232,10 @@ EXPORT_SYMBOL_GPL(iio_device_get_current_mode);
>  subsys_initcall(iio_init);
>  module_exit(iio_exit);
>  
> +#if IS_ENABLED(CONFIG_IIO_CHANNEL_PREFIX_KUNIT_TEST)
> +#include "test/iio-test-channel-prefix.c"
> +#endif

[Severity: Low]
If CONFIG_IIO=y and CONFIG_KUNIT=m, this code compiles the test directly into
the built-in industrialio-core.o object. Will this lead to an undefined
reference linker error when the built-in code attempts to reference KUnit
symbols exported by the loadable kunit.ko module?

> +
>  MODULE_AUTHOR("Jonathan Cameron <jic23@kernel.org>");
>  MODULE_DESCRIPTION("Industrial I/O core");
>  MODULE_LICENSE("GPL");
> diff --git a/drivers/iio/test/Kconfig b/drivers/iio/test/Kconfig
> index 4fc17dd0dcd77..c355b0abd5808 100644
> --- a/drivers/iio/test/Kconfig
> +++ b/drivers/iio/test/Kconfig
> @@ -4,6 +4,20 @@
>  #
>  
>  # Keep in alphabetical order
> +config IIO_CHANNEL_PREFIX_KUNIT_TEST
> +	bool "Test IIO channel prefix" if !KUNIT_ALL_TESTS
> +	depends on KUNIT && IIO

[Severity: Low]
Because IIO_CHANNEL_PREFIX_KUNIT_TEST is a bool, Kconfig allows it to be
enabled (y) even when its dependency evaluates to m (which happens when
KUNIT=m and IIO=y). Should this dependency be tightened to prevent the test
from being built-in while KUnit is a module?

> +	default KUNIT_ALL_TESTS
> +	help
> +	  Build unit tests for __iio_chan_prefix_emit(), the helper that

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260707-ad9910-iio-driver-v7-0-a4ec30f63700@analog.com?part=7