Re: [PATCH v7 16/17] iio: ABI: add docs for ad9910 sysfs and debugfs entries

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing 'Date:' field in newly added ABI documentation entries.
--

--- Patch [16]: [PATCH v7 16/17] iio: ABI: add docs for ad9910 sysfs and debugfs entries ---
commit 8529d81632ec7eacf5535d07efbbe35354e0d5d9
Author: Rodrigo Alencar <rodrigo.alencar@analog.com>

iio: ABI: add docs for ad9910 sysfs and debugfs entries

Add custom ABI documentation files for the DDS AD9910 with sysfs and
debugfs entries. The sysfs entries control Digital Ramp Generator and OSK
engine parameters, while debugfs attributes are read-only and evaluate
into source channel labels.

> diff --git a/Documentation/ABI/testing/debugfs-iio-ad9910 b/Documentation/ABI/testing/debugfs-iio-ad9910
> new file mode 100644
> index 0000000000000..b4a125bc10078
> --- /dev/null
> +++ b/Documentation/ABI/testing/debugfs-iio-ad9910
> @@ -0,0 +1,60 @@
> +What:		/sys/kernel/debug/iio/iio:deviceX/frequency_source
> +KernelVersion:	7.3
> +Contact:	linux-iio@vger.kernel.org

[Severity: Low]
Does this new ABI entry miss the mandatory Date field? The kernel ABI
documentation guidelines in Documentation/ABI/README typically require a
Date field to be present alongside What, KernelVersion, and Contact.

> +Description:
> +		Read-only. Reports the channel label that corresponds to which of the

[ ... ]

> diff --git a/Documentation/ABI/testing/sysfs-bus-iio-frequency-ad9910 b/Documentation/ABI/testing/sysfs-bus-iio-frequency-ad9910
> new file mode 100644
> index 0000000000000..4e25f538af4ad
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-bus-iio-frequency-ad9910
> @@ -0,0 +1,31 @@
> +What:		/sys/bus/iio/devices/iio:deviceX/out_altcurrentY_dwell_en
> +What:		/sys/bus/iio/devices/iio:deviceX/out_frequencyY_dwell_en
> +What:		/sys/bus/iio/devices/iio:deviceX/out_phaseY_dwell_en
> +KernelVersion:	7.3
> +Contact:	linux-iio@vger.kernel.org

[Severity: Low]
Should these sysfs ABI entries also include a Date field to fully comply
with the standard ABI documentation format?

> +Description:
> +		For a channel that produces parametric sweeps, this attribute controls

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260707-ad9910-iio-driver-v7-0-a4ec30f63700@analog.com?part=16