From: sashiko-bot@kernel.org
To: "Rodrigo Alencar" <rodrigo.alencar@analog.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v7 17/17] docs: iio: add documentation for ad9910 driver
Date: Tue, 07 Jul 2026 16:17:44 +0000 [thread overview]
Message-ID: <20260707161745.0286B1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260707-ad9910-iio-driver-v7-17-a4ec30f63700@analog.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing newline at the end of the newly added documentation file.
--
--- Patch [17]: [PATCH v7 17/17] docs: iio: add documentation for ad9910 driver ---
commit 96ab956a41cf5e3619f02b259c8c1dedbd083c07
Author: Rodrigo Alencar <rodrigo.alencar@analog.com>
docs: iio: add documentation for ad9910 driver
This commit adds documentation for the AD9910 DDS IIO driver. It describes
the channel hierarchy, operating modes, attributes, and provides sysfs ABI
usage examples.
> diff --git a/Documentation/iio/ad9910.rst b/Documentation/iio/ad9910.rst
> new file mode 100644
> index 0000000000000..ab5223c70c01a
> --- /dev/null
> +++ b/Documentation/iio/ad9910.rst
[ ... ]
> +Power down the device:
> +
> +.. code-block:: bash
> +
> + echo 1 > /sys/bus/iio/devices/iio\:device0/out_altcurrent100_powerdown
> \ No newline at end of file
[Severity: Low]
This isn't a bug, but could we add a terminating newline to the end of this
new documentation file? Missing EOF newlines typically trigger checkpatch
warnings and violate standard file formatting conventions.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260707-ad9910-iio-driver-v7-0-a4ec30f63700@analog.com?part=17
next prev parent reply other threads:[~2026-07-07 16:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 14:04 [PATCH v7 00/17] AD9910 Direct Digital Synthesizer Rodrigo Alencar via B4 Relay
2026-07-07 14:04 ` [PATCH v7 01/17] iio: ABI: add attributes for altcurrent channels Rodrigo Alencar via B4 Relay
2026-07-07 14:04 ` [PATCH v7 02/17] iio: ABI: scale and offset for frequency/phase channels Rodrigo Alencar via B4 Relay
2026-07-07 14:04 ` [PATCH v7 03/17] iio: ABI: add parent entry for iio channels Rodrigo Alencar via B4 Relay
2026-07-12 0:51 ` Jonathan Cameron
2026-07-07 14:04 ` [PATCH v7 04/17] iio: add IIO_FREQUENCY channel type Rodrigo Alencar via B4 Relay
2026-07-07 14:24 ` sashiko-bot
2026-07-07 14:04 ` [PATCH v7 05/17] iio: core: support 64-bit register through debugfs Rodrigo Alencar via B4 Relay
2026-07-07 14:04 ` [PATCH v7 06/17] iio: core: create local __iio_chan_prefix_emit() for reuse Rodrigo Alencar via B4 Relay
2026-07-07 15:58 ` Andy Shevchenko
2026-07-07 14:04 ` [PATCH v7 07/17] iio: test: add kunit tests for channel prefix naming generation Rodrigo Alencar via B4 Relay
2026-07-07 14:53 ` sashiko-bot
2026-07-12 1:09 ` Jonathan Cameron
2026-07-07 14:04 ` [PATCH v7 08/17] iio: core: add hierarchical channel relationships Rodrigo Alencar via B4 Relay
2026-07-07 16:00 ` Andy Shevchenko
2026-07-07 14:04 ` [PATCH v7 09/17] dt-bindings: iio: frequency: add ad9910 Rodrigo Alencar via B4 Relay
2026-07-07 16:11 ` Conor Dooley
2026-07-07 16:13 ` Conor Dooley
2026-07-07 14:04 ` [PATCH v7 10/17] iio: frequency: ad9910: initial driver implementation Rodrigo Alencar via B4 Relay
2026-07-07 15:15 ` sashiko-bot
2026-07-08 9:04 ` Uwe Kleine-König
2026-07-07 14:04 ` [PATCH v7 11/17] iio: frequency: ad9910: add basic parallel port support Rodrigo Alencar via B4 Relay
2026-07-07 14:04 ` [PATCH v7 12/17] iio: frequency: ad9910: add digital ramp generator support Rodrigo Alencar via B4 Relay
2026-07-07 14:04 ` [PATCH v7 13/17] iio: frequency: ad9910: add RAM mode support Rodrigo Alencar via B4 Relay
2026-07-07 15:51 ` sashiko-bot
2026-07-07 14:04 ` [PATCH v7 14/17] iio: frequency: ad9910: add output shift keying support Rodrigo Alencar via B4 Relay
2026-07-07 14:04 ` [PATCH v7 15/17] iio: frequency: ad9910: show channel priority in debugfs Rodrigo Alencar via B4 Relay
2026-07-07 14:04 ` [PATCH v7 16/17] iio: ABI: add docs for ad9910 sysfs and debugfs entries Rodrigo Alencar via B4 Relay
2026-07-07 16:16 ` sashiko-bot
2026-07-12 1:19 ` Jonathan Cameron
2026-07-07 14:04 ` [PATCH v7 17/17] docs: iio: add documentation for ad9910 driver Rodrigo Alencar via B4 Relay
2026-07-07 16:17 ` sashiko-bot [this message]
2026-07-12 1:35 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260707161745.0286B1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rodrigo.alencar@analog.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox