Re: [PATCH v3 14/20] media: imx355: Set the colorspace in the format

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Accessing a non-existent `format` field on a `struct v4l2_mbus_framefmt` pointer leads to a build failure.
--

--- Patch [14]: [PATCH v3 14/20] media: imx355: Set the colorspace in the format ---
commit 7db2a6f63330856f1837e4b7a0ae932c8ac63b94
Author: Dave Stevenson <dave.stevenson@raspberrypi.com>

media: imx355: Set the colorspace in the format

This commit sets the colorspace fields appropriately for a raw image
sensor in the imx355 driver.

> diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c
> index b27329143e481..2bf8da7469fe5 100644
> --- a/drivers/media/i2c/imx355.c
> +++ b/drivers/media/i2c/imx355.c
> @@ -612,6 +612,10 @@ static int imx355_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
>  	try_fmt->height = imx355->cur_mode->height;
>  	try_fmt->code = imx355_get_format_code(imx355);
>  	try_fmt->field = V4L2_FIELD_NONE;
> +	try_fmt->format.colorspace = V4L2_COLORSPACE_RAW;
> +	try_fmt->format.ycbcr_enc = V4L2_YCBCR_ENC_601;
> +	try_fmt->format.quantization = V4L2_QUANTIZATION_FULL_RANGE;
> +	try_fmt->format.xfer_func = V4L2_XFER_FUNC_NONE;

[Severity: Low]
Does this cause a build failure? try_fmt is a pointer to struct
v4l2_mbus_framefmt, which doesn't contain a format member.

Should this access the fields directly via try_fmt->colorspace and so on,
similar to how try_fmt->height is accessed just above this change?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-media-imx355-v3-0-9df386a623d7@raspberrypi.com?part=14