Re: [PATCH v3 12/20] media: imx355: Use pm_runtime autosuspend_delay

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The autosuspend optimization is bypassed during driver probe because `pm_runtime_idle()` is called before autosuspend is enabled.
--

--- Patch [12]: [PATCH v3 12/20] media: imx355: Use pm_runtime autosuspend_delay ---
commit c848098f5125edf42a401c819297cfe0a783116c
Author: Dave Stevenson <dave.stevenson@raspberrypi.com>

media: imx355: Use pm_runtime autosuspend_delay

This commit introduces pm_runtime autosuspend functionality to the imx355
sensor driver. It configures a 1000ms autosuspend delay to prevent 
unnecessary power cycling between operations.

> diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c
> index ee1f41a66a0b6..f01a1a5ae7c9a 100644
> --- a/drivers/media/i2c/imx355.c
> +++ b/drivers/media/i2c/imx355.c

[ ... ]

> @@ -1436,6 +1436,8 @@ static int imx355_probe(struct i2c_client *client)
>  	pm_runtime_set_active(imx355->dev);
>  	pm_runtime_enable(imx355->dev);
>  	pm_runtime_idle(imx355->dev);
> +	pm_runtime_set_autosuspend_delay(imx355->dev, 1000);
> +	pm_runtime_use_autosuspend(imx355->dev);

[Severity: Medium]
Does this sequence cause the device to power off immediately during probe?

Because pm_runtime_idle() is called before pm_runtime_use_autosuspend(), the
device usage count is 0 and autosuspend is not yet enabled. This seems to 
trigger a synchronous suspend right away, bypassing the 1000ms delay 
optimization intended by this patch.

Would it be better to reorder these so the autosuspend properties are 
configured before triggering the idle check?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-media-imx355-v3-0-9df386a623d7@raspberrypi.com?part=12