Re: [PATCH v3 11/20] media: imx355: Add support for get_selection

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Undeclared variable `crop` used in `imx355_set_pad_format()` causing a compilation error.
--

--- Patch [11]: [PATCH v3 11/20] media: imx355: Add support for get_selection ---
commit 16a5ac6200fbe4b75d8e6b726a26958a450dfdf0
Author: Dave Stevenson <dave.stevenson@raspberrypi.com>

media: imx355: Add support for get_selection

This commit provides all cropping information via get_selection. It updates
the subdev pad format operations to maintain crop rectangles in the try state
and implements the get_selection callback.

> diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c
> index c6f27cf269b40..ee1f41a66a0b6 100644
> --- a/drivers/media/i2c/imx355.c
> +++ b/drivers/media/i2c/imx355.c
[ ... ]
> @@ -869,6 +877,12 @@ imx355_set_pad_format(struct v4l2_subdev *sd,
>  	if (fmt->which == V4L2_SUBDEV_FORMAT_TRY) {
>  		framefmt = v4l2_subdev_state_get_format(sd_state, fmt->pad);
>  		*framefmt = fmt->format;
> +
> +		crop = v4l2_subdev_state_get_crop(sd_state, 0);

[Severity: Low]
Does this code introduce a compilation error? Looking at imx355_set_pad_format(),
it appears the crop variable is assigned and dereferenced here but is never
declared as a local variable within the function.

> +		crop->width = mode->crop.width;
> +		crop->height = mode->crop.height;
> +		crop->left = mode->crop.left;
> +		crop->top = mode->crop.top;
>  	} else {
>  		imx355->cur_mode = mode;
>  		/* Update limits and set FPS to default */

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-media-imx355-v3-0-9df386a623d7@raspberrypi.com?part=11