From: sashiko-bot@kernel.org
To: "Janani Sunil" <janani.sunil@analog.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH 2/6] iio: backend: Add support for CRC
Date: Thu, 09 Jul 2026 09:03:55 +0000 [thread overview]
Message-ID: <20260709090355.8D9B31F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260709-ad7768-driver-v1-2-44e1194fd96a@analog.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added `crc_enable` and `crc_disable` function pointers in `struct iio_backend_ops` are missing their corresponding descriptions in the kernel-doc block.
--
--- Patch [2]: [PATCH 2/6] iio: backend: Add support for CRC ---
commit 98a340052f70f8ab707e22920844ec1a36237e6a
Author: Janani Sunil <janani.sunil@analog.com>
iio: backend: Add support for CRC
This commit adds backend operations to enable or disable Cyclic Redundancy
Check (CRC) processing. This allows the backend to handle data integrity
verification for samples transmitted over the interface.
[ ... ]
> diff --git a/include/linux/iio/backend.h b/include/linux/iio/backend.h
> index 3f95ed1fdf9eb..197cf1ad5e68e 100644
> --- a/include/linux/iio/backend.h
> +++ b/include/linux/iio/backend.h
> @@ -189,6 +189,8 @@ struct iio_backend_ops {
> enum iio_backend_filter_type type);
> int (*interface_data_align)(struct iio_backend *back, u32 timeout_us);
> int (*num_lanes_set)(struct iio_backend *back, unsigned int num_lanes);
> + int (*crc_enable)(struct iio_backend *back);
> + int (*crc_disable)(struct iio_backend *back);
[Severity: Low]
Are the kernel-doc descriptions for crc_enable and crc_disable missing from
the documentation block above struct iio_backend_ops?
> int (*ddr_enable)(struct iio_backend *back);
> int (*ddr_disable)(struct iio_backend *back);
> int (*data_stream_enable)(struct iio_backend *back);
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260709-ad7768-driver-v1-0-44e1194fd96a@analog.com?part=2
next prev parent reply other threads:[~2026-07-09 9:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 8:50 [PATCH 0/6] iio: adc: Add AD7768/AD7768-4 ADC driver support Janani Sunil
2026-07-09 8:50 ` [PATCH 1/6] dt-bindings: iio: adc: Add AD7768 Janani Sunil
2026-07-09 8:59 ` sashiko-bot
2026-07-09 15:43 ` David Lechner
2026-07-10 0:33 ` Jonathan Cameron
2026-07-11 14:40 ` David Lechner
2026-07-12 1:39 ` Jonathan Cameron
2026-07-10 1:39 ` Jonathan Cameron
2026-07-09 8:50 ` [PATCH 2/6] iio: backend: Add support for CRC Janani Sunil
2026-07-09 9:03 ` sashiko-bot [this message]
2026-07-10 0:36 ` Jonathan Cameron
2026-07-09 8:50 ` [PATCH 3/6] iio: adc: adi-axi-adc: " Janani Sunil
2026-07-09 9:14 ` sashiko-bot
2026-07-09 15:54 ` David Lechner
2026-07-10 0:39 ` Jonathan Cameron
2026-07-10 0:46 ` Jonathan Cameron
2026-07-09 8:50 ` [PATCH 4/6] iio: adc: Add AD7768 IIO Driver support Janani Sunil
2026-07-09 9:27 ` sashiko-bot
2026-07-10 2:10 ` Jonathan Cameron
2026-07-10 7:41 ` Uwe Kleine-König
2026-07-09 8:50 ` [PATCH 5/6] gpio: ad7768: Add AD7768 GPIO auxiliary driver Janani Sunil
2026-07-09 9:38 ` sashiko-bot
2026-07-09 11:05 ` Andy Shevchenko
2026-07-10 2:14 ` Jonathan Cameron
2026-07-10 20:06 ` Linus Walleij
2026-07-09 8:50 ` [PATCH 6/6] Documentation: iio: Add AD7768 Documentation Janani Sunil
2026-07-09 9:41 ` sashiko-bot
2026-07-10 2:16 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260709090355.8D9B31F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=janani.sunil@analog.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox