Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Janani Sunil" <janani.sunil@analog.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 6/6] Documentation: iio: Add AD7768 Documentation
Date: Thu, 09 Jul 2026 09:41:42 +0000	[thread overview]
Message-ID: <20260709094142.B63291F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260709-ad7768-driver-v1-6-44e1194fd96a@analog.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The sysfs attribute ``in_voltage<N>_filter_type_available`` is split across two lines in the RST grid table, which will introduce an unwanted space when rendered.
--

--- Patch [6]: [PATCH 6/6] Documentation: iio: Add AD7768 Documentation ---
commit 14bceb1fc9d8c59930a466f42580515ee4eaaf95
Author: Janani Sunil <janani.sunil@analog.com>

Documentation: iio: Add AD7768 Documentation

This commit adds driver documentation for the Analog Devices AD7768 and
AD7768-4 ADCs. It covers supported features, power modes, data output
configurations, and IIO device attributes.

> diff --git a/Documentation/iio/ad7768.rst b/Documentation/iio/ad7768.rst
> new file mode 100644
> index 0000000000000..438e33d4f3759
> --- /dev/null
> +++ b/Documentation/iio/ad7768.rst
[ ... ]
> +Filter configuration
> +---------------------
> +
> ++---------------------------------------+--------------------------------------------------------------+
> +| Attribute                             | Description                                                  |
> ++=======================================+==============================================================+
> +| ``in_voltage<N>_filter_type``         | Current filter type for channel N: "wideband" or "sinc5".    |
> +|                                       | Channels assigned to the same mode profile share this value. |
> ++---------------------------------------+--------------------------------------------------------------+
> +| ``in_voltage<N>_filter_type_          | Available filter types for channel N: "wideband sinc5".      |
> +| available``                           |                                                              |

[Severity: Low]
This isn't a bug, but splitting the inline literal across two lines in
this RST grid table will cause Sphinx to insert an unwanted space. Does
this result in the sysfs attribute being incorrectly displayed as
in_voltage<N>_filter_type_ available in the rendered HTML or PDF output?

> ++---------------------------------------+--------------------------------------------------------------+

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709-ad7768-driver-v1-0-44e1194fd96a@analog.com?part=6

  reply	other threads:[~2026-07-09  9:41 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09  8:50 [PATCH 0/6] iio: adc: Add AD7768/AD7768-4 ADC driver support Janani Sunil
2026-07-09  8:50 ` [PATCH 1/6] dt-bindings: iio: adc: Add AD7768 Janani Sunil
2026-07-09  8:59   ` sashiko-bot
2026-07-09 15:43   ` David Lechner
2026-07-10  0:33     ` Jonathan Cameron
2026-07-11 14:40       ` David Lechner
2026-07-10  1:39   ` Jonathan Cameron
2026-07-09  8:50 ` [PATCH 2/6] iio: backend: Add support for CRC Janani Sunil
2026-07-09  9:03   ` sashiko-bot
2026-07-10  0:36   ` Jonathan Cameron
2026-07-09  8:50 ` [PATCH 3/6] iio: adc: adi-axi-adc: " Janani Sunil
2026-07-09  9:14   ` sashiko-bot
2026-07-09 15:54   ` David Lechner
2026-07-10  0:39   ` Jonathan Cameron
2026-07-10  0:46   ` Jonathan Cameron
2026-07-09  8:50 ` [PATCH 4/6] iio: adc: Add AD7768 IIO Driver support Janani Sunil
2026-07-09  9:27   ` sashiko-bot
2026-07-10  2:10   ` Jonathan Cameron
2026-07-10  7:41   ` Uwe Kleine-König
2026-07-09  8:50 ` [PATCH 5/6] gpio: ad7768: Add AD7768 GPIO auxiliary driver Janani Sunil
2026-07-09  9:38   ` sashiko-bot
2026-07-09 11:05   ` Andy Shevchenko
2026-07-10  2:14   ` Jonathan Cameron
2026-07-10 20:06   ` Linus Walleij
2026-07-09  8:50 ` [PATCH 6/6] Documentation: iio: Add AD7768 Documentation Janani Sunil
2026-07-09  9:41   ` sashiko-bot [this message]
2026-07-10  2:16   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260709094142.B63291F00A3A@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=janani.sunil@analog.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox