Re: [PATCH 1/6] dt-bindings: iio: adc: Add AD7768

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Hardware Variant Required Properties Violation: Missing GPIO provider properties in the required list
--

--- Patch [1]: [PATCH 1/6] dt-bindings: iio: adc: Add AD7768 ---
commit b348e8650b6dd32f354ad1a32b48736f30d333db
Author: Janani Sunil <janani.sunil@analog.com>

dt-bindings: iio: adc: Add AD7768

Devicetree Bindings for AD7768-4 (4 channel) and AD7768 (8 channel)
simultaneous sampling ADC

> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7768.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7768.yaml
> new file mode 100644
> index 0000000000000..b74fe6aef01c6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7768.yaml
[ ... ]
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - avdd-supply
> +  - avss-supply
> +  - dvdd-supply
> +  - iovdd-supply
> +  - vref-supply
> +  - adi,data-lines-number
> +  - adi,common-mode-output
> +  - io-backends

[Severity: Medium]
Since this hardware provides GPIO capabilities, should gpio-controller and
#gpio-cells be included in this required list? Omitting these allows
incomplete device tree nodes to silently pass schema validation.

[ ... ]
> +  - |
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        adc@1 {
> +            compatible = "adi,ad7768-4";
> +            reg = <1>;
> +            spi-max-frequency = <1000000>;
> +
> +            avdd-supply = <&avdd_regulator>;
> +            avss-supply = <&avss_regulator>;
> +            dvdd-supply = <&dvdd_regulator>;
> +            iovdd-supply = <&iovdd_regulator>;
> +            vref-supply = <&vref_regulator>;
> +
> +            clocks = <&ad7768_mclk>;
> +
> +            adi,data-lines-number = <4>;
> +            adi,common-mode-output = "2.14V";
> +            adi,power-mode = "fast";
> +
> +            io-backends = <&iio_backend>;

[Severity: Medium]
If the GPIO properties are added to the required list, they will also need
to be included in this example block to pass dt_binding_check validation.
Could gpio-controller and #gpio-cells = <2>; be added here?

> +
> +            #address-cells = <1>;
> +            #size-cells = <0>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709-ad7768-driver-v1-0-44e1194fd96a@analog.com?part=1