Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Shawn Guo" <shengchao.guo@oss.qualcomm.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v5 7/7] arm64: dts: qcom: Add device tree for IQ10 RRD board
Date: Thu, 09 Jul 2026 14:30:39 +0000	[thread overview]
Message-ID: <20260709143040.8441D1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260709132013.4096850-8-shengchao.guo@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] UFS reset GPIO pin index out of bounds for `gpio-ranges` in base devicetree.
--

--- Patch [7]: [PATCH v5 7/7] arm64: dts: qcom: Add device tree for IQ10 RRD board ---
commit ba7031927b18197ba50b6046132b0fba1999d651
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>

arm64: dts: qcom: Add device tree for IQ10 RRD board

This patch adds the initial device tree for the Qualcomm IQ10 RRD board, built
on the Nord Embedded variant. It enables the debug UART, UFS storage, PMICs,
I2C, and SPI.

> diff --git a/arch/arm64/boot/dts/qcom/iq10-rrd.dts b/arch/arm64/boot/dts/qcom/iq10-rrd.dts
> new file mode 100644
> index 0000000000000..39d254b49c147
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/iq10-rrd.dts
[ ... ]
> +&ufs_mem_hc {
> +	reset-gpios = <&tlmm 181 GPIO_ACTIVE_LOW>;

[Severity: Low]
Does this requested GPIO exceed the mapped gpio-ranges?

Looking at nord.dtsi, the gpio-ranges count is 181, which only covers
indices 0 through 180:

arch/arm64/boot/dts/qcom/nord.dtsi:tlmm {
        ...
        gpio-ranges = <&tlmm 0 0 181>;
        ...
}

Since the UFS reset pin is at index 181, requesting it falls outside the
pinctrl mapping. While this avoids a probe failure because the global GPIO
range overlaps and bypasses pinmux allocation, any attempt to apply pin
configuration (such as gpiod_set_config()) to the UFS reset pin will fail
because the pinctrl core will not be able to resolve the pin.

Should the gpio-ranges count in the base devicetree be updated to 182 to
accurately describe the hardware?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709132013.4096850-1-shengchao.guo@oss.qualcomm.com?part=7

      reply	other threads:[~2026-07-09 14:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09 13:20 [PATCH v5 0/7] Add initial device trees for Nord platform Shawn Guo
2026-07-09 13:20 ` [PATCH v5 1/7] arm64: dts: qcom: Add device tree for Nord SoC series Shawn Guo
2026-07-09 13:38   ` sashiko-bot
2026-07-09 13:20 ` [PATCH v5 2/7] arm64: dts: qcom: Add device tree for Nord GearVM variant Shawn Guo
2026-07-09 13:51   ` sashiko-bot
2026-07-09 13:20 ` [PATCH v5 3/7] dt-bindings: arm: qcom: Document SA8797P Ride board Shawn Guo
2026-07-09 13:20 ` [PATCH v5 4/7] arm64: dts: qcom: Add device tree for " Shawn Guo
2026-07-09 13:20 ` [PATCH v5 5/7] arm64: dts: qcom: Add device tree for Nord Embedded variant Shawn Guo
2026-07-09 13:20 ` [PATCH v5 6/7] dt-bindings: arm: qcom: Document Nord IQ10 RRD board Shawn Guo
2026-07-10  7:04   ` Krzysztof Kozlowski
2026-07-10  7:07     ` Krzysztof Kozlowski
2026-07-09 13:20 ` [PATCH v5 7/7] arm64: dts: qcom: Add device tree for " Shawn Guo
2026-07-09 14:30   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260709143040.8441D1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=shengchao.guo@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox