Re: [PATCH v3 02/18] dt-bindings: clock: mediatek: Make '#clock-cells' required for MT8192

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [Medium] The `mediatek,mt8192-infracfg` hardware variant acts as a reset provider, but `#reset-cells` is not conditionally enforced as a required property in the binding schema.
--

--- Patch [2]: [PATCH v3 02/18] dt-bindings: clock: mediatek: Make '#clock-cells' required for MT8192 ---
commit 39883f8dbf989e459d5a15ed6a9ba37e9a9a274b
Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>

dt-bindings: clock: mediatek: Make '#clock-cells' required for MT8192

This commit adds '#clock-cells' to the required properties list in both the
MT8192 clock and sys-clock device tree bindings. It ensures that clock
provider nodes define this property, as it is required for proper validation.

[ ... ]
> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt8192-sys-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt8192-sys-clock.yaml
> index bf8c9aacdf1e7..0ebd0d60e2f68 100644
> --- a/Documentation/devicetree/bindings/clock/mediatek,mt8192-sys-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/mediatek,mt8192-sys-clock.yaml
> @@ -35,6 +35,7 @@ properties:
>  required:
>    - compatible
>    - reg
> +  - '#clock-cells'

[Severity: Medium]
This isn't a bug introduced by this patch, but should an allOf block be added
here to conditionally enforce '#reset-cells' as required for the
mediatek,mt8192-infracfg variant?

The mediatek,mt8192-infracfg hardware variant acts as a reset provider, but
without enforcing '#reset-cells' in an if-then block, incomplete device tree
nodes will silently pass dt_binding_check validation. This can lead to
potential runtime failures when dependent subsystems try to consume the reset.

Additionally, the example node for infracfg is missing '#reset-cells = <1>;':

Documentation/devicetree/bindings/clock/mediatek,mt8192-sys-clock.yaml:
  - |
    infracfg: syscon@10001000 {
        compatible = "mediatek,mt8192-infracfg", "syscon";
        reg = <0x10001000 0x1000>;
        #clock-cells = <1>;
    };

Should the example be updated to properly validate the reset provider
capabilities?

>  
>  additionalProperties: false

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260720-mt8189-clocks-system-base-v3-0-8e6d99ab3ad2@collabora.com?part=2