Re: [PATCH v3 03/18] dt-bindings: clock: mediatek: Make '#clock-cells' required for MT8195

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [Medium] The `mediatek,mt8195-sys-clock.yaml` binding documents `#reset-cells` but fails to enforce it as a required property for the `mediatek,mt8195-infracfg_ao` hardware variant, which acts as a reset provider.
--

--- Patch [3]: [PATCH v3 03/18] dt-bindings: clock: mediatek: Make '#clock-cells' required for MT8195 ---
commit e850c4d6a26f7542acffe18dab094b9f9089cde6
Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>

dt-bindings: clock: mediatek: Make '#clock-cells' required for MT8195

Both MT8195 clock controllers dt-bindings (clock and sys-clock)
document the #clock-cells property but do not enforce it as required
property. This commit adds it to the required property list in both
dt-bindings files to ensure clock provider nodes define this property.

[ ... ]

> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt8195-sys-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt8195-sys-clock.yaml
> index 69f096eb168d1..ba1b36fa01699 100644
> --- a/Documentation/devicetree/bindings/clock/mediatek,mt8195-sys-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/mediatek,mt8195-sys-clock.yaml
> @@ -43,6 +43,7 @@ properties:
>  required:
>    - compatible
>    - reg
> +  - '#clock-cells'

[Severity: Medium]
This is a pre-existing issue, but the mediatek,mt8195-sys-clock.yaml binding
documents #reset-cells but fails to enforce it as a required property for the
mediatek,mt8195-infracfg_ao hardware variant, which acts as a reset provider.

Should #reset-cells also be added as a required property for the reset
provider variant, perhaps in an allOf conditional block? A missing
conditional constraint allows an incomplete device tree missing #reset-cells
to pass schema validation, and dependent drivers attempting to use the resets
could fail at runtime.

Additionally, the example for infracfg_ao omits the #reset-cells property:

    infracfg_ao: syscon@10001000 {
        compatible = "mediatek,mt8195-infracfg_ao", "syscon";
        reg = <0x10001000 0x1000>;
        #clock-cells = <1>;
    };

Does the example need to be updated to demonstrate all provider capabilities
to properly pass dt_binding_check validation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260720-mt8189-clocks-system-base-v3-0-8e6d99ab3ad2@collabora.com?part=3