Re: [PATCH v3 07/18] dt-bindings: clock: mediatek: regroup MT8195 dt-bindings into MT8186

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `if-then` conditional block for MT8188 compatible strings incorrectly uses `enum:` instead of `contains: enum:`, breaking schema validation.
--

--- Patch [7]: [PATCH v3 07/18] dt-bindings: clock: mediatek: regroup MT8195 dt-bindings into MT8186 ---
commit 962476a7bda22cd1057abbb9118e372c99b1e154
Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>

dt-bindings: clock: mediatek: regroup MT8195 dt-bindings into MT8186

This commit regroups the MT8195 clock and system clock dt-bindings into
the MT8186 bindings to ease maintainability. The standalone MT8195 files
are removed and their compatible strings are added to the shared schemas.

> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
> index b5988d122e4dd..ab9f8cb7dd6ee 100644
> --- a/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
> @@ -78,6 +78,31 @@ properties:
>            - mediatek,mt8192-vdecsys_soc
>            - mediatek,mt8192-vdecsys
>            - mediatek,mt8192-vencsys
> +          - mediatek,mt8195-apusys_pll
[ ... ]
> +          - mediatek,mt8195-wpesys_vpp0
> +          - mediatek,mt8195-wpesys_vpp1
>  
>    reg:
>      maxItems: 1

[Severity: Low]
Is the if-then conditional block for MT8188 compatible strings missing
a contains keyword?

Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml:allOf.if.properties.compatible:
        compatible:
          enum:
            - mediatek,mt8188-camsys-rawa

Because the Device Tree compatible property is parsed as a string array,
using enum directly against the array will unconditionally evaluate to false.
As a result, the else clause ('#reset-cells': false) is incorrectly applied
to all nodes.

Could this forbid the '#reset-cells' property for MT8188 nodes (e.g.,
camsys-rawa) that validly define it, breaking schema validation when
running make dtbs_check on MT8188 device trees?

This regression was introduced by the series in the commit "dt-bindings:
clock: mediatek: regroup MT8188 dt-bindings into MT8186" when the contains
keyword was mistakenly dropped.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260720-mt8189-clocks-system-base-v3-0-8e6d99ab3ad2@collabora.com?part=7