Re: [PATCH v3 05/18] dt-bindings: clock: mediatek: regroup MT8188 dt-bindings into MT8186

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `allOf` `if` block in `mediatek,mt8186-clock.yaml` uses `enum` instead of `contains: enum` to match `compatible` strings, forcing `#reset-cells` to be erroneously forbidden for MT8188 variants.
--

--- Patch [5]: [PATCH v3 05/18] dt-bindings: clock: mediatek: regroup MT8188 dt-bindings into MT8186 ---
commit 98d8c49a88c351f004575c4b25d83403e1fe67e1
Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>

dt-bindings: clock: mediatek: regroup MT8188 dt-bindings into MT8186

This commit regroups the MT8188 clock and system clock device tree bindings
into the MT8186 ones. The goal is to ease maintainability by having common
files for multiple SoCs that share the same kind of clock controller design.

> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
> --- a/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
[ ... ]
> @@ -42,11 +65,36 @@ properties:
>    '#clock-cells':
>      const: 1
>  
> +  '#reset-cells':
> +    const: 1
> +
>  required:
>    - compatible
>    - reg
>    - '#clock-cells'
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - mediatek,mt8188-camsys-rawa

[Severity: Medium]
Does this enum properly match the compatible property?

Because compatible is treated as an array of strings in device tree schemas,
matching it with a direct enum instead of "contains: enum" evaluates to false. 

Will this cause the else branch to activate and incorrectly enforce 
"#reset-cells: false" on MT8188 variants that actually require it, causing
schema validation failures during dtbs_check?

> +            - mediatek,mt8188-camsys-rawb
> +            - mediatek,mt8188-camsys-yuva
> +            - mediatek,mt8188-camsys-yuvb
> +            - mediatek,mt8188-imgsys-wpe1
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260720-mt8189-clocks-system-base-v3-0-8e6d99ab3ad2@collabora.com?part=5