Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jun Nie <jun.nie@linaro.org>
Cc: Rob Clark <robin.clark@oss.qualcomm.com>,
	 Dmitry Baryshkov <lumag@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	 Abhinav Kumar <abhinav.kumar@linux.dev>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	 Sean Paul <sean@poorly.run>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	 David Airlie <airlied@gmail.com>,
	Simona Vetter <simona@ffwll.ch>,
	 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	 Thomas Zimmermann <tzimmermann@suse.de>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	 freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/6] dt-bindings: display: panel: Modify reset gpio number constrain
Date: Mon, 27 Jul 2026 22:23:29 +0200	[thread overview]
Message-ID: <20260727-stirring-miraculous-nautilus-e22bda@quoll> (raw)
In-Reply-To: <20260727-sm8650-7-1-bonded-dsi-v5-1-c042266b9eeb@linaro.org>

On Mon, Jul 27, 2026 at 04:08:40PM +0800, Jun Nie wrote:
> Some panel support 2 reset gpio, such as Synaptics R63455. So modify the

There is no such binding for R63455.

> number constrain of gpio to 1 to avoid check failure.

What check failure? Please paste actual warnings (but not fake ones).

> 
> Signed-off-by: Jun Nie <jun.nie@linaro.org>
> ---
>  Documentation/devicetree/bindings/display/panel/panel-common.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-common.yaml b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> index 087415753d606..7c450d2799808 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-common.yaml
> @@ -119,7 +119,7 @@ properties:
>        confused with a backlight enable signal.
>  
>    reset-gpios:
> -    maxItems: 1
> +    minItems: 1

I do not get why all bindings now get completely flexible number of
resets. I am pretty sure not all of them constrain that. It's rather
your task to check it and explain in commit msg.

For example the second random I took to check (ILI7807S) does not
restrict, so you just made that binding accepting 1000 reset lines. Why?

Best regards,
Krzysztof


  parent reply	other threads:[~2026-07-27 20:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27  8:08 [PATCH v5 0/6] Add support to 2 panels in bonded-DSI mode Jun Nie
2026-07-27  8:08 ` [PATCH v5 1/6] dt-bindings: display: panel: Modify reset gpio number constrain Jun Nie
2026-07-27  8:18   ` sashiko-bot
2026-07-27 20:23   ` Krzysztof Kozlowski [this message]
2026-07-27 20:24   ` Krzysztof Kozlowski
2026-07-27  8:08 ` [PATCH v5 2/6] drm/msm/dsi: support DSC configurations with slice_per_pkt > 1 Jun Nie
2026-07-27  8:08 ` [PATCH v5 3/6] drm/mipi-dsi: Add flag to support dual-panel configurations Jun Nie
2026-07-27  8:08 ` [PATCH v5 4/6] drm/msm/dsi: Support dual panel use case with single CRTC Jun Nie
2026-07-27  8:25   ` sashiko-bot
2026-07-27  8:08 ` [PATCH v5 5/6] dt-bindings: display: Add Synaptics R63455 panel support Jun Nie
2026-07-27  8:18   ` sashiko-bot
2026-07-27  9:47   ` Rob Herring (Arm)
2026-07-27 20:42     ` Krzysztof Kozlowski
2026-07-27 20:29   ` Krzysztof Kozlowski
2026-07-27  8:08 ` [PATCH v5 6/6] drm/panel: Add driver for Synaptics R63455 DSI panel Jun Nie
2026-07-27  8:20   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260727-stirring-miraculous-nautilus-e22bda@quoll \
    --to=krzk@kernel.org \
    --cc=abhinav.kumar@linux.dev \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=jun.nie@linaro.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marijn.suijten@somainline.org \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox