Re: [PATCH v7 01/34] dt-bindings: pinctrl: airoha: en7581: fix misprint in i2s function name

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [Low] Incomplete fix: identical copy-paste misprint for 'i2s' function was missed in the sibling binding 'airoha,an7583-pinctrl.yaml'.
--

--- Patch [1]: [PATCH v7 01/34] dt-bindings: pinctrl: airoha: en7581: fix misprint in i2s function name ---
commit 0749f859891dd657945c83f8003df4b6494d5a24
Author: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>

dt-bindings: pinctrl: airoha: en7581: fix misprint in i2s function name

This patch fixes a misprint in the EN7581 pinctrl binding where the "i2c"
pin function was defined twice, hiding the "i2s" pin function. The correction
aligns the binding with the actual pinctrl driver.

> diff --git a/Documentation/devicetree/bindings/pinctrl/airoha,en7581-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/airoha,en7581-pinctrl.yaml
> --- a/Documentation/devicetree/bindings/pinctrl/airoha,en7581-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/airoha,en7581-pinctrl.yaml
> @@ -166,7 +166,7 @@ patternProperties:
>            - if:
>                properties:
>                  function:
> -                  const: i2c
> +                  const: i2s

[Severity: Low]
This isn't a bug introduced by this patch, but does the same misprint exist
in the sibling binding for the AN7583?

Looking at Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml
in the patternProperties:^mux(-|$):allOf block:

          - if:
              properties:
                function:
                  const: i2c
            then:
              properties:
                groups:
                  enum: [i2s]

Should this file also be updated alongside the EN7581 changes to prevent
schema validation from improperly failing when checking the i2c or i2s pin
functions on the AN7583 SoC?

>              then:
>                properties:
>                  groups:
>                    enum: [i2s]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727074234.3761170-1-mikhail.kshevetskiy@iopsys.eu?part=1