Re: [PATCH v7 31/34] pinctrl: airoha: try to find chip scu node by phandle first

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The fallback logic unconditionally catches all errors from `syscon_regmap_lookup_by_phandle()` (including `-EPROBE_DEFER` and `-ENOMEM`), which can mask critical errors by overwriting them with permanent `-ENODEV` failures.
--

--- Patch [31]: [PATCH v7 31/34] pinctrl: airoha: try to find chip scu node by phandle first ---
commit bdb88d3420346c0c992b6bccf51e7ae7eb4e0a9a
Author: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>

pinctrl: airoha: try to find chip scu node by phandle first

This patch updates the probe function to first search for the chip SCU regmap
using the airoha,chip-scu phandle. If that fails, it falls back to searching
by a SoC-specific compatible string to maintain compatibility across different
chip variants.

> diff --git a/drivers/pinctrl/airoha/pinctrl-airoha.c b/drivers/pinctrl/airoha/pinctrl-airoha.c
> index a671d34b334eb..460010c001eb2 100644
> --- a/drivers/pinctrl/airoha/pinctrl-airoha.c
> +++ b/drivers/pinctrl/airoha/pinctrl-airoha.c
> @@ -748,9 +748,12 @@ int airoha_pinctrl_probe(struct platform_device *pdev)
>  	if (IS_ERR(pinctrl->regmap))
>  		return PTR_ERR(pinctrl->regmap);
>  
> -	map = syscon_regmap_lookup_by_compatible("airoha,en7581-chip-scu");
> -	if (IS_ERR(map))
> -		return PTR_ERR(map);
> +	map = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, "airoha,chip-scu");
> +	if (IS_ERR_OR_NULL(map)) {

[Severity: High]
Does this error check unintentionally mask -EPROBE_DEFER?

If the device tree uses the modern phandle binding but the SCU syscon is not
ready, syscon_regmap_lookup_by_phandle() returns -EPROBE_DEFER.

Because this check unconditionally catches all errors, it will fall back to
syscon_regmap_lookup_by_compatible(). If the legacy compatible string isn't
present in the device tree, that fallback returns -ENODEV, which overwrites
the original -EPROBE_DEFER and causes a permanent probe failure instead of
deferring.

Should the fallback only be executed if the initial lookup returns -ENODEV?

> +		map = syscon_regmap_lookup_by_compatible(data->chip_scu_compatible);
> +		if (IS_ERR(map))
> +			return PTR_ERR(map);
> +	}
>  
>  	pinctrl->chip_scu = map;
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727074234.3761170-1-mikhail.kshevetskiy@iopsys.eu?part=31