Re: [PATCH v7 24/34] pinctrl: airoha: an7583: add support for npu_uart pinmux

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit adds support for the 'npu_uart' pin group in the pinctrl driver for the 'uart' function but fails to update the corresponding device tree bindings.
--

--- Patch [24]: [PATCH v7 24/34] pinctrl: airoha: an7583: add support for npu_uart pinmux ---
commit e389a2bc465838a0c68580627d10aa31667842fb
Author: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>

pinctrl: airoha: an7583: add support for npu_uart pinmux

This commit adds support for the npu_uart pin function and group to the 
AN7583 pinctrl driver.

> diff --git a/drivers/pinctrl/airoha/pinctrl-an7583.c b/drivers/pinctrl/airoha/pinctrl-an7583.c
> index b0b1dbbb4d768..9b5c7ea5e5472 100644
> --- a/drivers/pinctrl/airoha/pinctrl-an7583.c
> +++ b/drivers/pinctrl/airoha/pinctrl-an7583.c
[ ... ]
> @@ -569,7 +570,7 @@ static const char *const sipo_groups[] = { "sipo", "sipo_rclk" };
>  static const char *const mdio_groups[] = { "mdio" };
>  static const char *const uart_groups[] = {
>  	"uart2", "uart2_cts_rts", "hsuart", "hsuart_cts_rts",
> -	"uart4", "uart5"
> +	"uart4", "uart5", "npu_uart"

[Severity: Low]
Should npu_uart also be added to the device tree bindings in
Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml?

If a device tree uses this new group, it appears it will fail make dtbs_check
validation because npu_uart is not listed in the allowed groups for the uart
function:

Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml:
          - if:
              properties:
                function:
                  const: uart
            then:
              properties:
                groups:
                  items:
                    enum: [uart2, uart2_cts_rts, hsuart, hsuart_cts_rts,
                           uart4, uart5]

>  };
>  static const char *const jtag_groups[] = { "jtag_udi", "jtag_dfd" };
>  static const char *const pcm_groups[] = { "pcm1", "pcm2" };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727074234.3761170-1-mikhail.kshevetskiy@iopsys.eu?part=24